Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added an option to ignore General Macros with import/export #46

Closed

Conversation

pgarneau
Copy link

Hello!

I was finding it frustrating that I was losing general macros on characters that didn't use Myslot when using the ClearMacro functionality.

Added an option to ignore general macros and only import/export/clear character specific macros

@pgarneau
Copy link
Author

@tg123

@tg123
Copy link
Owner

tg123 commented Jun 1, 2024

image
the ui is confusing,

do you mind change it to

Ignore Import Export [Macro drop down] 
                                        - All Macro
                                        - General
                                        - Character specific

also i am thinking to support

Ignore Import Export [Action] 
                                        - All
                                        - 1
                                        - 2
                                        - 3
                                        - ...
                                        - 12

@pgarneau
Copy link
Author

pgarneau commented Jun 1, 2024

You want one single drop down menu for all ignore import/export?

What about the clear section?

You will have one side of the UI that will be small and other side will be still large

@tg123
Copy link
Owner

tg123 commented Jun 2, 2024

agreed, any idea to make the ui better to understand?

@tg123
Copy link
Owner

tg123 commented Jun 8, 2024

first POC
image

still too complex

@pgarneau
Copy link
Author

pgarneau commented Jun 8, 2024

Could Do something like this:

Myslot is already a complex addon, I think this would be fine.

   Ignore during Import/Export: DROPDOWN                       Clear during Import: DROPDOWN
                                        -> Action Bars                                                             -> Action Bars
                                        -> Key Bindings                                                           -> Key Bindings
                                        -> General Macros                                                       -> General Macros
                                        -> Character Specific Macros                                 -> Character Specific Macros                                                                             

@tg123
Copy link
Owner

tg123 commented Jun 13, 2024

will draft ui as you suggested and lets work together to close this

@pgarneau
Copy link
Author

will draft ui as you suggested and lets work together to close this

Working on it at the moment. I found a bug in the "ignore general macro" where it wouldn't reimport the general macro on the action bars. Fixed it, but it's not super elegant. I'm trusting the index stored in the action bar data. What if that general macro got deleted and a new one is there? The "placed" macro will be wrong. Might add some logic that checks if the macro name exists or something.

Here's a quick draft

image

@pgarneau
Copy link
Author

@tg123 Thoughts?

image

@pgarneau
Copy link
Author

I think we should make the text window smaller, but keep the old checkboxes.

More clear what options are enabled/disabled at the time of import.

Nobody reads the text anyways

@pgarneau
Copy link
Author

you can add me on discord if you want to chat more easily:

username: doll

@pgarneau pgarneau closed this Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants