Fix cases of readonly on [Import]'s #350
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both OpenDocumentResult and ShowToolResult imported IShell but their member variable was set to readonly, which resulted in a composition exception (member is not writable, see below). They are no longer readonly.
Additionally. no code was actually making use of the Show.Document/Tool helpers, which is likely how this went uncaught, despite the README.md providing an example of it for the HomeViewModel. ViewHome and ViewToolboxCommandHandler now use Show class instead of importing IShell themselves.