Skip to content

Commit

Permalink
Small fixes (single-spa#392)
Browse files Browse the repository at this point in the history
* Fix links that point to localhost

* Add missing word

* Fix typo

* Remove extra title
  • Loading branch information
filoxo authored Jan 15, 2021
1 parent c147c29 commit ae91a29
Show file tree
Hide file tree
Showing 6 changed files with 7 additions and 9 deletions.
2 changes: 1 addition & 1 deletion website/blog/2020-02-24-single-spa-5.md
Original file line number Diff line number Diff line change
Expand Up @@ -92,4 +92,4 @@ This change does not mean anything drastic for single-spa. Its license was and i

We are actively [translating the single-spa documentation to Chinese](https://github.com/single-spa/zh-hans.single-spa.js.org), and hope to add other languages soon. We will add full [Angular 9 support](https://github.com/single-spa/single-spa-angular/issues?utf8=%E2%9C%93&q=is%3Aissue+is%3Aopen+angular+9) soon, and hope to add [server rendering](https://github.com/single-spa/single-spa/issues/103) in an upcoming release.

Please [contribute to our code](http://localhost:3000/docs/next/contributing-overview) and [ecosystem](/docs/ecosystem), [join our single-spa slack channel](https://join.slack.com/t/single-spa/shared_invite/zt-jy1x8x93-52Tth0fZBUzZmHcEpWw2Jg), [follow our official Twitter account](https://twitter.com/Single_spa), and contribute to [our open collective](https://opencollective.com/single-spa). The [single-spa core team](/contributors) all have full-time jobs and maintain this project on a volunteer basis.
Please [contribute to our code](/docs/contributing-overview) and [ecosystem](/docs/ecosystem), [join our single-spa slack channel](https://join.slack.com/t/single-spa/shared_invite/zt-jy1x8x93-52Tth0fZBUzZmHcEpWw2Jg), [follow our official Twitter account](https://twitter.com/Single_spa), and contribute to [our open collective](https://opencollective.com/single-spa). The [single-spa core team](/contributors) all have full-time jobs and maintain this project on a volunteer basis.
4 changes: 2 additions & 2 deletions website/versioned_docs/version-4.x/ecosystem-angular.md
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,7 @@ In order for the [webpack public path](https://webpack.js.org/guides/public-path
"single-spa helpers" refers to the in-browser portion of single-spa-angular. The helpers are used by all versions of Angular and
regardless of whether you are using Angular CLI or not. This is the core of the single-spa-angular library that makes it possible
for Angular applications to bootstrap, mount, and unmount. See
[single-spa lifecycles](http://localhost:3000/docs/building-applications.html#registered-application-lifecycle) for more information.
[single-spa lifecycles](/docs/building-applications.html#registered-application-lifecycle) for more information.

## Basic usage

Expand Down Expand Up @@ -487,7 +487,7 @@ is the preferred way to do it.
#### Option 2

If you want the scripts to only be loaded when needed, you can add a custom
[bootstrap lifecycle](http://localhost:3000/docs/building-applications.html#bootstrap) to your code.
[bootstrap lifecycle](/docs/building-applications.html#bootstrap) to your code.

Note that lazy loading these scripts can actually be worse for performance _if you always need them_, since
they will start downloading later than if you put them right into the root HTML file.
Expand Down
2 changes: 1 addition & 1 deletion website/versioned_docs/version-5.x/api.md
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,7 @@ console.log(status); // one of many statuses (see list below). e.g. MOUNTED
</div>
<div>
<dt>LOADING_SOURCE_CODE</dt>
<dd>'s source code is being fetched.</dd>
<dd>app's source code is being fetched.</dd>
</div>
<div>
<dt>NOT_BOOTSTRAPPED</dt>
Expand Down
4 changes: 2 additions & 2 deletions website/versioned_docs/version-5.x/ecosystem-angular.md
Original file line number Diff line number Diff line change
Expand Up @@ -344,7 +344,7 @@ In order for the [webpack public path](https://webpack.js.org/guides/public-path
"single-spa helpers" refers to the in-browser portion of single-spa-angular. The helpers are used by all versions of Angular and
regardless of whether you are using Angular CLI or not. This is the core of the single-spa-angular library that makes it possible
for Angular applications to bootstrap, mount, and unmount. See
[single-spa lifecycles](http://localhost:3000/docs/building-applications.html#registered-application-lifecycle) for more information.
[single-spa lifecycles](/docs/building-applications.html#registered-application-lifecycle) for more information.

### Migrating from [email protected] to [email protected]

Expand Down Expand Up @@ -633,7 +633,7 @@ is the preferred way to do it.
#### Option 2

If you want the scripts to only be loaded when needed, you can add a custom
[bootstrap lifecycle](http://localhost:3000/docs/building-applications.html#bootstrap) to your code.
[bootstrap lifecycle](/docs/building-applications.html#bootstrap) to your code.

Note that lazy loading these scripts can actually be worse for performance _if you always need them_, since
they will start downloading later than if you put them right into the root HTML file.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ As your architecture matures, you may add more shared dependencies in the future
if using single-spa Layout Engine

- Remove the existing `<application name="@single-spa/welcome"></application>` element
- Add your own `<application name=""></application>` element using the `name` the module name used in the import map from the previous ste
- Add your own `<application name=""></application>` element using the `name` the module name used in the import map from the previous step

Thats it! Your first single-spa application should now be running in your root-config.

Expand Down
2 changes: 0 additions & 2 deletions website/versioned_docs/version-5.x/single-spa-playground.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@ title: single-spa-playground
sidebar_label: Playground
---

# Single-spa Playground

[Playground website](http://single-spa-playground.org)

[Github project](https://github.com/single-spa/single-spa-playground)
Expand Down

0 comments on commit ae91a29

Please sign in to comment.