Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing definition for matrix falcon #2395

Merged
merged 2 commits into from
Dec 21, 2024
Merged

Conversation

ValdisThomann
Copy link
Contributor

@ValdisThomann ValdisThomann commented Dec 21, 2024

VIA firmware already exists for this board, but no v3 json. This PR fixes that.

Description

QMK Pull Request

Already in main
https://github.com/qmk/qmk_firmware/tree/master/keyboards/matrix/falcon

VIA Keymap Pull Request

Already in main
https://github.com/the-via/qmk_userspace_via/tree/main/keyboards/matrix/falcon/keymaps/via

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • VIA keymap is MERGED in VIA userspace master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • I have formatted the JSON file to have consistent formatting with the rest of the repository.
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

@ValdisThomann ValdisThomann merged commit ecc0521 into master Dec 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant