Skip to content

Commit

Permalink
Minor refactoring to RoaringBitmapArraySuite.
Browse files Browse the repository at this point in the history
GitOrigin-RevId: eb77c958731b273964277b6dc01f033df573bd25
  • Loading branch information
larsk-db authored and vkorukanti committed Nov 29, 2022
1 parent b3ff96c commit 80b1224
Showing 1 changed file with 21 additions and 18 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -122,13 +122,14 @@ class RoaringBitmapArraySuite extends SparkFunSuite {
bitmap
}

for (serializationFormat <- RoaringBitmapArrayFormat.values)
test(s"serialization - $serializationFormat") {
checkSerializeDeserialize(RoaringBitmapArray(), serializationFormat)
checkSerializeDeserialize(RoaringBitmapArray(1L), serializationFormat)
checkSerializeDeserialize(RoaringBitmapArray(BITMAP2_NUMBER), serializationFormat)
checkSerializeDeserialize(RoaringBitmapArray(1L, BITMAP2_NUMBER), serializationFormat)
checkSerializeDeserialize(allContainerTypesBitmap, serializationFormat)
for (serializationFormat <- RoaringBitmapArrayFormat.values) {
test(s"serialization - $serializationFormat") {
checkSerializeDeserialize(RoaringBitmapArray(), serializationFormat)
checkSerializeDeserialize(RoaringBitmapArray(1L), serializationFormat)
checkSerializeDeserialize(RoaringBitmapArray(BITMAP2_NUMBER), serializationFormat)
checkSerializeDeserialize(RoaringBitmapArray(1L, BITMAP2_NUMBER), serializationFormat)
checkSerializeDeserialize(allContainerTypesBitmap, serializationFormat)
}
}

private def checkSerializeDeserialize(
Expand All @@ -143,19 +144,21 @@ class RoaringBitmapArraySuite extends SparkFunSuite {
assert(input === output)
}

for (serializationFormat <- RoaringBitmapArrayFormat.values)
test(s"serialization and deserialization with big endian buffers throws - $serializationFormat") {
val roaringBitmapArray = RoaringBitmapArray(1L)
val bigEndianBuffer = ByteBuffer
.allocate(roaringBitmapArray.serializedSizeInBytes(serializationFormat).toInt)
.order(ByteOrder.BIG_ENDIAN)
for (serializationFormat <- RoaringBitmapArrayFormat.values) {
test(
s"serialization and deserialization with big endian buffers throws - $serializationFormat") {
val roaringBitmapArray = RoaringBitmapArray(1L)
val bigEndianBuffer = ByteBuffer
.allocate(roaringBitmapArray.serializedSizeInBytes(serializationFormat).toInt)
.order(ByteOrder.BIG_ENDIAN)

assertThrows[IllegalArgumentException] {
roaringBitmapArray.serialize(bigEndianBuffer, serializationFormat)
}
assertThrows[IllegalArgumentException] {
roaringBitmapArray.serialize(bigEndianBuffer, serializationFormat)
}

assertThrows[IllegalArgumentException] {
roaringBitmapArray.deserialize(bigEndianBuffer)
assertThrows[IllegalArgumentException] {
roaringBitmapArray.deserialize(bigEndianBuffer)
}
}
}

Expand Down

0 comments on commit 80b1224

Please sign in to comment.