fix: missing if around alert

thediamonder11 · Oct 22, 2024 · fcc5955 · fcc5955
1 parent 8c4a491
commit fcc5955
Showing 1 changed file with 12 additions and 8 deletions.
diff --git a/src/announcement-data/systems/stations/AmeyPhil.tsx b/src/announcement-data/systems/stations/AmeyPhil.tsx
@@ -6397,10 +6397,12 @@ export default class AmeyPhil extends StationAnnouncementSystem {
       [...destinationLocations.map(l => l.crs), ...callingPoints.map(l => l.crsCode)].filter(Boolean) as string[]
     ).filter(c => !this.STATIONS.includes(c))
     const invalidStationNames = invalidStationCrses.map(c => `- ${crsToStationItemMapper(c).name}`)
-    alert(
-      "Some stations in this train's calling pattern are not available with this announcement system. The following locations have been removed:\n" +
-        invalidStationNames.join('\n'),
-    )
+    if (invalidStationNames.length > 0) {
+      alert(
+        "Some stations in this train's calling pattern are not available with this announcement system. The following locations have been removed:\n" +
+          invalidStationNames.join('\n'),
+      )
+    }
 
     const invalidDestinationCrses = destinationLocations.filter(d => !d.crs || !this.STATIONS.includes(d.crs)).map(d => d.crs!!)
     if (invalidDestinationCrses.length > 0) {
@@ -6527,10 +6529,12 @@ export default class AmeyPhil extends StationAnnouncementSystem {
 
     const invalidStationCrses = (callingPoints.map(l => l.crsCode).filter(Boolean) as string[]).filter(c => !this.STATIONS.includes(c))
     const invalidStationNames = invalidStationCrses.map(c => `- ${crsToStationItemMapper(c).name}`)
-    alert(
-      "Some stations in this train's calling pattern are not available with this announcement system. The following locations have been removed:\n" +
-        invalidStationNames.join('\n'),
-    )
+    if (invalidStationNames.length > 0) {
+      alert(
+        "Some stations in this train's calling pattern are not available with this announcement system. The following locations have been removed:\n" +
+          invalidStationNames.join('\n'),
+      )
+    }
 
     const invalidDestinationCrses = destinationLocations.filter(d => !d.crs || !this.STATIONS.includes(d.crs)).map(d => d.crs!!)
     if (invalidDestinationCrses.length > 0) {