Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: use svelte cli instead of create-svelte and svelte-add #1502

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gemb0y
Copy link

@gemb0y gemb0y commented Dec 15, 2024

📑 Description

With version 5 of svelte, svelte-add and create-svelte commands are deprecated. Svelte cli is the new way to go so the docs have been updated to replace:

  • npm create svelte@latest my-project by npx sv create my-project
  • npx svelte-add@latest tailwindcss by npx sv add tailwindcss

Note

I did not change the commands in src/routes/icons/svelte-4.md since it specifically talks about svelte 4 icons

Status

  • Not Completed
  • Completed

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • I have checked the page with https://validator.unl.edu/
  • All the tests have passed
  • My pull request is based on the latest commit (not the npm version).

ℹ Additional Information

Summary by CodeRabbit

  • New Features

    • Updated installation commands for Svelte and Tailwind CSS in documentation.
    • Enhanced documentation for accessibility features and optimization of icon usage in Svelte applications.
  • Documentation

    • Improved clarity and structure of installation steps in quickstart guides.
    • Added detailed explanations for icon props and performance benefits.

Copy link

vercel bot commented Dec 15, 2024

@0ranga is attempting to deploy a commit to the Themesberg Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

coderabbitai bot commented Dec 15, 2024

Walkthrough

The pull request updates the documentation for SvelteKit and Flowbite Svelte installation instructions across two markdown files. The primary changes involve modifying command-line instructions for project creation and dependency installation, with a focus on simplifying the setup process. The updates standardize the commands from npm-based syntax to a new npx sv approach and emphasize the use of pnpm for package management.

Changes

File Change Summary
src/routes/docs/pages/introduction.md Updated installation commands from npm create svelte@latest my-app to npx sv create my-app and npx svelte-add@latest tailwindcss to npx sv add tailwindcss
src/routes/docs/pages/quickstart.md Modified SvelteKit and Tailwind CSS installation commands, added explicit pnpm package management instructions, specified Flowbite Svelte installation with pnpm i -D flowbite-svelte flowbite

Poem

🐰 Hop, skip, and a command update!
New syntax makes setup more neat
npx sv takes the stage
Simplifying our dev page
Documentation's fresh delight! 🚀

Tip

CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command @coderabbitai generate docstrings to have CodeRabbit automatically generate docstrings for your pull request. This feature will be included in our Pro Plan when released.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 06b1036 and ca67a89.

📒 Files selected for processing (2)
  • src/routes/docs/pages/introduction.md (2 hunks)
  • src/routes/docs/pages/quickstart.md (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
  • src/routes/docs/pages/introduction.md
  • src/routes/docs/pages/quickstart.md

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🔭 Outside diff range comments (1)
src/routes/icons/svelte-4.md (1)

Line range hint 1-7: Resolve version inconsistency in documentation.

The page title indicates "Svelte 4 Icons" but the description mentions "Svelte 5". This might confuse users about version compatibility.

-description: Get started with a collection of open-source Svelte 5 powered icons built by the Flowbite community and based on the official design
+description: Get started with a collection of open-source Svelte 4 powered icons built by the Flowbite community and based on the official design
🧹 Nitpick comments (3)
src/routes/docs/pages/quickstart.md (1)

26-28: Ensure project name consistency across documentation.

The project name my-app is used here, but other documentation files use my-project. Let's maintain consistency across all files.

-npx sv create my-app
+npx sv create my-project
 cd my-app
 pnpm install
src/routes/docs/pages/introduction.md (1)

27-29: Ensure project name consistency across documentation.

The project name my-app is used here, but other documentation files use my-project. Let's maintain consistency across all files.

-npx sv create my-app
+npx sv create my-project
 cd my-app
 pnpm install
src/routes/icons/svelte-4.md (1)

38-41: Ensure project name consistency and fix directory change command.

The project name and directory change command need to be consistent with other documentation files.

-npx sv create my-app
-cd my-project
+npx sv create my-project
+cd my-project
 npx sv add tailwindcss
 pnpm i
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2257cbc and 243b0fa.

📒 Files selected for processing (3)
  • src/routes/docs/pages/introduction.md (2 hunks)
  • src/routes/docs/pages/quickstart.md (2 hunks)
  • src/routes/icons/svelte-4.md (1 hunks)
🔇 Additional comments (2)
src/routes/docs/pages/quickstart.md (1)

46-48: LGTM! Command updated correctly.

The Tailwind CSS installation command has been correctly updated to use the new Svelte CLI syntax.

src/routes/docs/pages/introduction.md (1)

47-48: LGTM! Command updated correctly.

The Tailwind CSS installation command has been correctly updated to use the new Svelte CLI syntax.

@gemb0y gemb0y force-pushed the update_docs_to_use_svelte_cli branch from 243b0fa to 06b1036 Compare December 15, 2024 22:19
With version 5 of svelte, svelte-add and create-svelte commands
are deprecated. Svelte cli is the new way to go so the docs have been
updated to replace:

- npm create svelte@latest my-project by npx sv create my-project
- npx svelte-add@latest tailwindcss by npx sv add tailwindcss
@gemb0y gemb0y force-pushed the update_docs_to_use_svelte_cli branch from 06b1036 to ca67a89 Compare December 15, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant