fix maxBucketSize #41
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #41 +/- ##
=======================================
Coverage 85.43% 85.43%
=======================================
Files 7 7
Lines 728 728
=======================================
Hits 622 622
Misses 78 78
Partials 28 28
Continue to review full report at Codecov.
|
zhiqiangxu
force-pushed
the
fix_maxBucketSize
branch
2 times, most recently
from
8f3b8f3
to
d8eade5
Compare
zhiqiangxu
force-pushed
the
fix_maxBucketSize
branch
from
d8eade5
to
e52c692
Compare
|
@theodesp Could you help verify this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to make
maxBucketSizemore close to(log n) + 1.i.e, it returns 1 for size 1, returns 2 for size 2,3, returns 3 for size 4,5,6,7 etc.