Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow monolog/monolog ^2.0 #106

Merged
merged 1 commit into from
May 24, 2022
Merged

Allow monolog/monolog ^2.0 #106

merged 1 commit into from
May 24, 2022

Conversation

dmnc
Copy link
Contributor

@dmnc dmnc commented May 16, 2022

All my testing indicates that monolog 2 is supported by 0.6. Merging this and releasing 0.6.1 should allow people to use whichever version of monolog they prefer.

None of the instantiation done by this package should be affected by the changes: https://github.com/Seldaek/monolog/blob/main/UPGRADE.md#200

Of course, in user land, people may be using handlers in their config that monolog no longer supports.

Closes #90

@dmnc
Copy link
Contributor Author

dmnc commented May 23, 2022

@andymc Could I hassle you a little for a look at this one please? I think once this is merged the package becomes usable for new installs again.

Copy link
Collaborator

@andymc andymc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for the delay!

@andymc andymc merged commit 9ea42aa into theorchard:master May 24, 2022
@dmnc dmnc deleted the allow-monolog-2 branch June 21, 2022 10:41
@glensc glensc mentioned this pull request Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for monolog "^2.0"?
2 participants