-
Notifications
You must be signed in to change notification settings - Fork 538
[SDK] Fix: Apply accentButtonText theme key to the Spinner inside of PayEmbed Buttons #7110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDK] Fix: Apply accentButtonText theme key to the Spinner inside of PayEmbed Buttons #7110
Conversation
🦋 Changeset detectedLatest commit: 4ab3604 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
WalkthroughThe changes update the color prop for Spinner components within loading states in two UI files. Specifically, the Spinner color changes from "accentText" to "accentButtonText" in both the fiat and swap quote screens. No other logic, control flow, or public interfaces are modified. Changes
Sequence Diagram(s)No sequence diagram is generated as the changes are limited to UI color props and do not affect control flow or feature logic. Note ⚡️ AI Code Reviews for VS Code, Cursor, WindsurfCodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback. Note ⚡️ Faster reviews with cachingCodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 30th. To opt out, configure 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
@RobbyUitbeijerse is attempting to deploy a commit to the thirdweb Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you!
Various components in the codebase were a spinner was rendered inside a button, the
accentButtonText
key was applied to the spinner. This seems to make a bit more sense compared to usingaccentText
which will make it hard to give the button a light color while keeping the rest dark, since the spinner color is related to the accentText rather than the button text colour.Attached is a situation I was running into:

Changing the theme key that's applied to be
accentTextButton
throughout all components rendered inside of a makes things nice and consistent, and resolves the above scenario.PR-Codex overview
This PR focuses on fixing the theme color of the loading spinner in the
PayEmbed
component to enhance visual consistency.Detailed summary
color
prop of the<Spinner>
component inFiatScreenContent.tsx
fromaccentText
toaccentButtonText
.color
prop of the<Spinner>
component inSwapScreenContent.tsx
fromaccentText
toaccentButtonText
.Summary by CodeRabbit