Skip to content

[Dashboard] migrate authorized wallets components to shadcn #7131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jnsdls
Copy link
Member

@jnsdls jnsdls commented May 22, 2025

Summary

  • migrate authorized wallets revoke modal from Chakra to shadcn dialog
  • replace Chakra button/text in AuthorizedWalletsTable with shadcn + tailwind
  • drop Chakra provider wrapper from account devices page
  • cleanup modal title/description and remove node cache

Testing

  • pnpm biome check --apply apps/dashboard/src/components/settings/AuthorizedWallets/AuthorizedWalletRevokeModal.tsx .gitignore
  • pnpm test (fails: spawn anvil ENOENT)

PR-Codex overview

This PR focuses on refactoring the AccountDevicesPage and related components to replace the ChakraProviderSetup with a new Dialog component for better UI management, along with updates to the AuthorizedWalletRevokeModal and AuthorizedWalletsTable for improved functionality and styling.

Detailed summary

  • Removed ChakraProviderSetup from AccountDevicesPage.
  • Introduced a Dialog component in AuthorizedWalletRevokeModal.
  • Updated modal structure and styling in AuthorizedWalletRevokeModal.
  • Replaced useDisclosure with local state management for modal visibility in AuthorizedWalletsTable.
  • Changed button styles to use a new destructive variant.
  • Updated text rendering from Text components to span elements for consistency.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

  • Refactor

    • Replaced Chakra UI components with custom UI library components in wallet authorization modals and tables.
    • Updated modal and button styling for a consistent look and feel.
    • Simplified modal state management in the authorized wallets table.
  • Chores

    • Updated .gitignore to exclude dashboard node compilation cache.

@jnsdls jnsdls requested review from a team as code owners May 22, 2025 21:12
@jnsdls jnsdls added the codex label May 22, 2025 — with ChatGPT Connector
Copy link

changeset-bot bot commented May 22, 2025

⚠️ No Changeset found

Latest commit: 70a519a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented May 22, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 23, 2025 4:01am
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 23, 2025 4:01am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 23, 2025 4:01am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 23, 2025 4:01am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 23, 2025 4:01am

Copy link
Contributor

graphite-app bot commented May 22, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

Copy link
Contributor

coderabbitai bot commented May 22, 2025

Walkthrough

The updates replace Chakra UI components and hooks with custom UI primitives and React state management in the authorized wallets feature of the dashboard app. Modal and button components are swapped for local versions, and text rendering is adjusted. Additionally, a node compilation cache directory is added to the .gitignore file.

Changes

File(s) Change Summary
.gitignore Added apps/dashboard/node-compile-cache to the ignore list.
apps/dashboard/src/app/(app)/account/devices/AccountDevicesPage.tsx Removed ChakraProviderSetup wrapper and related comment from the page component.
apps/dashboard/src/components/settings/AuthorizedWallets/AuthorizedWalletRevokeModal.tsx Refactored to use custom Dialog components instead of Chakra UI modal components; updated modal structure and styling.
apps/dashboard/src/components/settings/AuthorizedWallets/AuthorizedWalletsTable.tsx Replaced Chakra UI hooks with React useState; swapped Chakra UI button and text components for local UI primitives; updated styling and state handling.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant AccountDevicesPage
    participant AuthorizedWalletsTable
    participant AuthorizedWalletRevokeModal

    User->>AccountDevicesPage: Navigates to Devices Page
    AccountDevicesPage->>AuthorizedWalletsTable: Renders table with wallet devices
    User->>AuthorizedWalletsTable: Clicks "Revoke Access" button
    AuthorizedWalletsTable->>AuthorizedWalletRevokeModal: Opens revoke modal (via local state)
    User->>AuthorizedWalletRevokeModal: Confirms revoke
    AuthorizedWalletRevokeModal->>AuthorizedWalletsTable: Calls onRevoke callback
    AuthorizedWalletsTable->>AuthorizedWalletRevokeModal: Closes modal
Loading

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between eab902b and 70a519a.

📒 Files selected for processing (4)
  • .gitignore (1 hunks)
  • apps/dashboard/src/app/(app)/account/devices/AccountDevicesPage.tsx (1 hunks)
  • apps/dashboard/src/components/settings/AuthorizedWallets/AuthorizedWalletRevokeModal.tsx (2 hunks)
  • apps/dashboard/src/components/settings/AuthorizedWallets/AuthorizedWalletsTable.tsx (6 hunks)
🚧 Files skipped from review as they are similar to previous changes (4)
  • .gitignore
  • apps/dashboard/src/app/(app)/account/devices/AccountDevicesPage.tsx
  • apps/dashboard/src/components/settings/AuthorizedWallets/AuthorizedWalletsTable.tsx
  • apps/dashboard/src/components/settings/AuthorizedWallets/AuthorizedWalletRevokeModal.tsx
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: Size
  • GitHub Check: Lint Packages
  • GitHub Check: Analyze (javascript)
✨ Finishing Touches
  • 📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented May 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.61%. Comparing base (678c00e) to head (70a519a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7131   +/-   ##
=======================================
  Coverage   55.61%   55.61%           
=======================================
  Files         902      902           
  Lines       58177    58177           
  Branches     4085     4085           
=======================================
  Hits        32356    32356           
  Misses      25716    25716           
  Partials      105      105           
Flag Coverage Δ
packages 55.61% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

github-actions bot commented May 22, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 56.62 KB (0%) 1.2 s (0%) 204 ms (+202.95% 🔺) 1.4 s
thirdweb (cjs) 309.13 KB (0%) 6.2 s (0%) 609 ms (+13.12% 🔺) 6.8 s
thirdweb (minimal + tree-shaking) 5.69 KB (0%) 114 ms (0%) 71 ms (+1413.58% 🔺) 185 ms
thirdweb/chains (tree-shaking) 531 B (0%) 11 ms (0%) 29 ms (+1393.75% 🔺) 40 ms
thirdweb/react (minimal + tree-shaking) 19.5 KB (0%) 390 ms (0%) 86 ms (+617.24% 🔺) 476 ms

Copy link
Contributor

graphite-app bot commented May 23, 2025

Merge activity

## Summary
- migrate authorized wallets revoke modal from Chakra to shadcn dialog
- replace Chakra button/text in AuthorizedWalletsTable with shadcn + tailwind
- drop Chakra provider wrapper from account devices page
- cleanup modal title/description and remove node cache

## Testing
- `pnpm biome check --apply apps/dashboard/src/components/settings/AuthorizedWallets/AuthorizedWalletRevokeModal.tsx .gitignore`
- `pnpm test` *(fails: spawn anvil ENOENT)*

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on refactoring the `AccountDevicesPage` and the `AuthorizedWalletRevokeModal` components to replace the `Chakra UI` modal with a new `Dialog` component. It also updates the `AuthorizedWalletsTable` to use local state for modal visibility and modifies UI elements for consistency.

### Detailed summary
- Removed `ChakraProviderSetup` from `AccountDevicesPage`.
- Replaced `Modal` components with `Dialog` components in `AuthorizedWalletRevokeModal`.
- Updated modal structure and styling in `AuthorizedWalletRevokeModal`.
- Changed state management for modal visibility in `AuthorizedWalletsTable`.
- Updated text rendering from `Text` to `span` for consistency in `AuthorizedWalletsTable`.
- Changed button styles in `AuthorizedWalletsTable` for revocation actions.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->

<!-- This is an auto-generated comment: release notes by coderabbit.ai -->

## Summary by CodeRabbit

- **Refactor**
  - Replaced Chakra UI components with custom UI library components in wallet authorization modals and tables.
  - Updated modal and button styling for a consistent look and feel.
  - Simplified modal state management in the authorized wallets table.

- **Chores**
  - Updated `.gitignore` to exclude dashboard node compilation cache.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codex Dashboard Involves changes to the Dashboard.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants