-
Notifications
You must be signed in to change notification settings - Fork 538
[Dashboard] migrate authorized wallets components to shadcn #7131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dashboard] migrate authorized wallets components to shadcn #7131
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
WalkthroughThe updates replace Chakra UI components and hooks with custom UI primitives and React state management in the authorized wallets feature of the dashboard app. Modal and button components are swapped for local versions, and text rendering is adjusted. Additionally, a node compilation cache directory is added to the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant AccountDevicesPage
participant AuthorizedWalletsTable
participant AuthorizedWalletRevokeModal
User->>AccountDevicesPage: Navigates to Devices Page
AccountDevicesPage->>AuthorizedWalletsTable: Renders table with wallet devices
User->>AuthorizedWalletsTable: Clicks "Revoke Access" button
AuthorizedWalletsTable->>AuthorizedWalletRevokeModal: Opens revoke modal (via local state)
User->>AuthorizedWalletRevokeModal: Confirms revoke
AuthorizedWalletRevokeModal->>AuthorizedWalletsTable: Calls onRevoke callback
AuthorizedWalletsTable->>AuthorizedWalletRevokeModal: Closes modal
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (4)
🚧 Files skipped from review as they are similar to previous changes (4)
⏰ Context from checks skipped due to timeout of 90000ms (3)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7131 +/- ##
=======================================
Coverage 55.61% 55.61%
=======================================
Files 902 902
Lines 58177 58177
Branches 4085 4085
=======================================
Hits 32356 32356
Misses 25716 25716
Partials 105 105
🚀 New features to boost your workflow:
|
size-limit report 📦
|
Merge activity
|
## Summary - migrate authorized wallets revoke modal from Chakra to shadcn dialog - replace Chakra button/text in AuthorizedWalletsTable with shadcn + tailwind - drop Chakra provider wrapper from account devices page - cleanup modal title/description and remove node cache ## Testing - `pnpm biome check --apply apps/dashboard/src/components/settings/AuthorizedWallets/AuthorizedWalletRevokeModal.tsx .gitignore` - `pnpm test` *(fails: spawn anvil ENOENT)* <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on refactoring the `AccountDevicesPage` and the `AuthorizedWalletRevokeModal` components to replace the `Chakra UI` modal with a new `Dialog` component. It also updates the `AuthorizedWalletsTable` to use local state for modal visibility and modifies UI elements for consistency. ### Detailed summary - Removed `ChakraProviderSetup` from `AccountDevicesPage`. - Replaced `Modal` components with `Dialog` components in `AuthorizedWalletRevokeModal`. - Updated modal structure and styling in `AuthorizedWalletRevokeModal`. - Changed state management for modal visibility in `AuthorizedWalletsTable`. - Updated text rendering from `Text` to `span` for consistency in `AuthorizedWalletsTable`. - Changed button styles in `AuthorizedWalletsTable` for revocation actions. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Replaced Chakra UI components with custom UI library components in wallet authorization modals and tables. - Updated modal and button styling for a consistent look and feel. - Simplified modal state management in the authorized wallets table. - **Chores** - Updated `.gitignore` to exclude dashboard node compilation cache. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
eab902b
to
70a519a
Compare
Summary
Testing
pnpm biome check --apply apps/dashboard/src/components/settings/AuthorizedWallets/AuthorizedWalletRevokeModal.tsx .gitignore
pnpm test
(fails: spawn anvil ENOENT)PR-Codex overview
This PR focuses on refactoring the
AccountDevicesPage
and related components to replace theChakraProviderSetup
with a newDialog
component for better UI management, along with updates to theAuthorizedWalletRevokeModal
andAuthorizedWalletsTable
for improved functionality and styling.Detailed summary
ChakraProviderSetup
fromAccountDevicesPage
.Dialog
component inAuthorizedWalletRevokeModal
.AuthorizedWalletRevokeModal
.useDisclosure
with local state management for modal visibility inAuthorizedWalletsTable
.destructive
variant.Text
components tospan
elements for consistency.Summary by CodeRabbit
Refactor
Chores
.gitignore
to exclude dashboard node compilation cache.