Remove SIWA feedback buttons from nebula #7142

MananTank · 2025-05-23T15:51:18Z

PR-Codex overview

This PR primarily focuses on refactoring the Chats component by removing the teamId prop from various instances and eliminating the feedback functionality. It simplifies the component's structure and reduces unnecessary complexity.

Detailed summary

Removed teamId prop from multiple instances of Chats.
Deleted the entire FeedbackButtons component and its associated logic.
Updated imports in Chats.tsx, removing unused imports.
Simplified the RenderMessage function by removing feedback-related code.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

New Features
- None.
Bug Fixes
- None.
Refactor
- Removed the feedback feature, including thumbs up/down buttons and related tracking, from chat components.
- Simplified chat components by removing the unused or redundant team selection prop.
Chores
- Cleaned up code by deleting unnecessary feedback-related imports and props.

vercel · 2025-05-23T15:51:21Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
thirdweb-www	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 23, 2025 4:09pm

4 Skipped Deployments

Name	Status	Updated (UTC)
docs-v2	⬜️ Skipped (Inspect)	May 23, 2025 4:09pm
login	⬜️ Skipped (Inspect)	May 23, 2025 4:09pm
thirdweb_playground	⬜️ Skipped (Inspect)	May 23, 2025 4:09pm
wallet-ui	⬜️ Skipped (Inspect)	May 23, 2025 4:09pm

changeset-bot · 2025-05-23T15:51:21Z

⚠️ No Changeset found

Latest commit: d1ca9af

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2025-05-23T15:51:24Z

Walkthrough

This change removes the teamId prop from all usages of the Chats component and deletes all feedback-related UI and logic, including feedback buttons and tracking, from the Chats.tsx file. No other logic, control flow, or error handling is modified in the affected components.

Changes

File(s)	Change Summary
`.../components/Chats.tsx`	Removed `teamId` prop from `Chats` and `RenderMessage` components; deleted all feedback UI and logic, including `FeedbackButtons`, related imports, and tracking.
`.../components/ChatPageContent.tsx` `.../components/Chats.stories.tsx` `.../components/CustomChat/CustomChatContent.tsx` `.../components/FloatingChat/FloatingChatContent.tsx`	Removed explicit passing of `teamId` prop (either as `undefined` or from parent props) to `Chats` component.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant ChatPageContent/CustomChatContent/FloatingChatContent
    participant Chats

    User->>ChatPageContent/CustomChatContent/FloatingChatContent: Interacts with chat interface
    ChatPageContent/CustomChatContent/FloatingChatContent->>Chats: Render Chats (no teamId prop)
    Chats->>Chats: Render messages (no feedback UI)
    User->>Chats: Interact with messages (no feedback buttons)

Possibly related PRs

thirdweb-dev/js#7128: Adds the teamId prop and introduces feedback buttons and submission logic to Chats.tsx, directly modifying the same areas of code but in the opposite direction of this PR.

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)

TEAM-0000: Entity not found: Issue - Could not find referenced Issue.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bc7b382 and d1ca9af.

📒 Files selected for processing (5)

apps/dashboard/src/app/nebula-app/(app)/components/ChatPageContent.tsx (0 hunks)
apps/dashboard/src/app/nebula-app/(app)/components/Chats.stories.tsx (0 hunks)
apps/dashboard/src/app/nebula-app/(app)/components/Chats.tsx (1 hunks)
apps/dashboard/src/app/nebula-app/(app)/components/CustomChat/CustomChatContent.tsx (0 hunks)
apps/dashboard/src/app/nebula-app/(app)/components/FloatingChat/FloatingChatContent.tsx (0 hunks)

💤 Files with no reviewable changes (4)

apps/dashboard/src/app/nebula-app/(app)/components/CustomChat/CustomChatContent.tsx
apps/dashboard/src/app/nebula-app/(app)/components/Chats.stories.tsx
apps/dashboard/src/app/nebula-app/(app)/components/FloatingChat/FloatingChatContent.tsx
apps/dashboard/src/app/nebula-app/(app)/components/ChatPageContent.tsx

🚧 Files skipped from review as they are similar to previous changes (1)

apps/dashboard/src/app/nebula-app/(app)/components/Chats.tsx

⏰ Context from checks skipped due to timeout of 90000ms (8)

GitHub Check: Unit Tests
GitHub Check: E2E Tests (pnpm, esbuild)
GitHub Check: Lint Packages
GitHub Check: E2E Tests (pnpm, webpack)
GitHub Check: Build Packages
GitHub Check: E2E Tests (pnpm, vite)
GitHub Check: Size
GitHub Check: Analyze (javascript)

✨ Finishing Touches

📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

MananTank · 2025-05-23T15:51:34Z

Remove SIWA feedback buttons from nebula #7142 👈 (View in Graphite)
main

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

merge-queue - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

codecov · 2025-05-23T15:54:06Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.63%. Comparing base (317211a) to head (d1ca9af).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #7142   +/-   ##
=======================================
  Coverage   55.63%   55.63%           
=======================================
  Files         902      902           
  Lines       58190    58190           
  Branches     4098     4098           
=======================================
  Hits        32373    32373           
  Misses      25712    25712           
  Partials      105      105

Flag	Coverage Δ
packages	`55.63% <ø> (ø)`

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

github-actions · 2025-05-23T15:56:08Z

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
thirdweb (esm)	56.62 KB (0%)	1.2 s (0%)	185 ms (+148.96% 🔺)	1.4 s
thirdweb (cjs)	309.13 KB (0%)	6.2 s (0%)	574 ms (-1.8% 🔽)	6.8 s
thirdweb (minimal + tree-shaking)	5.69 KB (0%)	114 ms (0%)	89 ms (+1668.97% 🔺)	203 ms
thirdweb/chains (tree-shaking)	531 B (0%)	11 ms (0%)	18 ms (+1087.9% 🔺)	29 ms
thirdweb/react (minimal + tree-shaking)	19.5 KB (0%)	390 ms (0%)	50 ms (+179.87% 🔺)	440 ms

graphite-app · 2025-05-23T16:02:04Z

Merge activity

May 23, 4:02 PM UTC: MananTank added this pull request to the Graphite merge queue.
May 23, 4:10 PM UTC: Merged by the Graphite merge queue.

--- ## PR-Codex overview This PR primarily focuses on refactoring the `Chats` component and its related functionalities. It removes unused code and simplifies the props being passed, particularly the `teamId`. Additionally, it eliminates the feedback buttons and associated functionality. ### Detailed summary - Removed `teamId` prop from various instances of the `Chats` component. - Deleted the `FeedbackButtons` component and its related logic. - Simplified imports in the `Chats` component by removing unused imports. - Cleaned up the `RenderMessage` function by omitting `teamId` from props. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`   ## Summary by CodeRabbit - **New Features** - None. - **Bug Fixes** - None. - **Refactor** - Removed the feedback feature, including thumbs up/down buttons and related tracking, from chat components. - Simplified chat components by removing the unused or redundant team selection prop. - **Chores** - Cleaned up code by deleting unnecessary feedback-related imports and props.

vercel bot temporarily deployed to Preview – docs-v2 May 23, 2025 15:51 Inactive

vercel bot temporarily deployed to Preview – login May 23, 2025 15:51 Inactive

vercel bot temporarily deployed to Preview – wallet-ui May 23, 2025 15:51 Inactive

vercel bot temporarily deployed to Preview – thirdweb_playground May 23, 2025 15:51 Inactive

MananTank marked this pull request as ready for review May 23, 2025 15:51

MananTank requested review from a team as code owners May 23, 2025 15:51

github-actions bot added the Dashboard Involves changes to the Dashboard. label May 23, 2025

github-actions bot assigned MananTank May 23, 2025

MananTank added the hotfix This pull request should be prioritized in the merge queue. label May 23, 2025 — with Graphite App

vercel bot deployed to Preview – thirdweb-www May 23, 2025 15:58 View deployment

joaquim-verges approved these changes May 23, 2025

View reviewed changes

graphite-app bot force-pushed the 05-23-remove_siwa_feedback_buttons_from_nebula branch from bc7b382 to d1ca9af Compare May 23, 2025 16:02

vercel bot temporarily deployed to Preview – docs-v2 May 23, 2025 16:02 Inactive

vercel bot temporarily deployed to Preview – thirdweb_playground May 23, 2025 16:02 Inactive

vercel bot temporarily deployed to Preview – login May 23, 2025 16:02 Inactive

vercel bot temporarily deployed to Preview – wallet-ui May 23, 2025 16:02 Inactive

vercel bot deployed to Preview – thirdweb-www May 23, 2025 16:09 View deployment

graphite-app bot merged commit d1ca9af into main May 23, 2025
24 checks passed

graphite-app bot removed the hotfix This pull request should be prioritized in the merge queue. label May 23, 2025

graphite-app bot deleted the 05-23-remove_siwa_feedback_buttons_from_nebula branch May 23, 2025 16:10

vercel bot temporarily deployed to Production – thirdweb_playground May 23, 2025 16:10 Inactive

vercel bot temporarily deployed to Production – docs-v2 May 23, 2025 16:10 Inactive

vercel bot temporarily deployed to Production – wallet-ui May 23, 2025 16:10 Inactive

vercel bot temporarily deployed to Production – login May 23, 2025 16:10 Inactive

vercel bot deployed to Production – thirdweb-www May 23, 2025 16:17 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Remove SIWA feedback buttons from nebula #7142

Remove SIWA feedback buttons from nebula #7142

MananTank commented May 23, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

vercel bot commented May 23, 2025 •

edited

Loading

Uh oh!

changeset-bot bot commented May 23, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented May 23, 2025 •

edited

Loading

Review ran into problems

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

MananTank commented May 23, 2025 •

edited

Loading

Uh oh!

codecov bot commented May 23, 2025 •

edited

Loading

Uh oh!

github-actions bot commented May 23, 2025 •

edited

Loading

Uh oh!

graphite-app bot commented May 23, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Remove SIWA feedback buttons from nebula #7142

Remove SIWA feedback buttons from nebula #7142

Conversation

MananTank commented May 23, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR-Codex overview

Detailed summary

Summary by CodeRabbit

Uh oh!

vercel bot commented May 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented May 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

coderabbitai bot commented May 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Possibly related PRs

Review ran into problems

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

MananTank commented May 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

codecov bot commented May 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented May 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

graphite-app bot commented May 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Uh oh!

MananTank commented May 23, 2025 •

edited by coderabbitai bot

Loading

vercel bot commented May 23, 2025 •

edited

Loading

changeset-bot bot commented May 23, 2025 •

edited

Loading

coderabbitai bot commented May 23, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

MananTank commented May 23, 2025 •

edited

Loading

codecov bot commented May 23, 2025 •

edited

Loading

github-actions bot commented May 23, 2025 •

edited

Loading

graphite-app bot commented May 23, 2025 •

edited

Loading