-
Notifications
You must be signed in to change notification settings - Fork 538
Version Packages #7149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version Packages #7149
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WalkthroughThis change removes a documentation file for webhook verification, updates changelogs for two packages, and increments their version numbers. It also updates the Changes
Possibly related PRs
Suggested labels
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/thirdweb/CHANGELOG.md (1)
14-25
: Clarify example snippet context
The code block uses a top-levelawait
and an import from"thirdweb/bridge"
. For clarity:
- Note that top-level
await
requires an ES module environment (or wrap this call in anasync
function).- Confirm that
thirdweb/bridge
is the correct entry point for theWebhook
export.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
.changeset/webhook-verification.md
(0 hunks)packages/thirdweb/CHANGELOG.md
(1 hunks)packages/thirdweb/package.json
(2 hunks)packages/wagmi-adapter/CHANGELOG.md
(1 hunks)packages/wagmi-adapter/package.json
(1 hunks)
💤 Files with no reviewable changes (1)
- .changeset/webhook-verification.md
⏰ Context from checks skipped due to timeout of 90000ms (8)
- GitHub Check: E2E Tests (pnpm, esbuild)
- GitHub Check: E2E Tests (pnpm, webpack)
- GitHub Check: Unit Tests
- GitHub Check: Size
- GitHub Check: E2E Tests (pnpm, vite)
- GitHub Check: Lint Packages
- GitHub Check: Build Packages
- GitHub Check: Analyze (javascript)
🔇 Additional comments (6)
packages/wagmi-adapter/CHANGELOG.md (1)
3-3
: Changelog: Add new version entry 0.2.83
The header for version 0.2.83 has been inserted correctly to reflect the package bump.packages/wagmi-adapter/package.json (1)
3-3
: package.json: Bump version to 0.2.83
The package version has been updated from 0.2.82 to 0.2.83, aligning with the release automation.packages/thirdweb/package.json (2)
3-3
: Version bump to 5.101.0 looks correct.
This aligns with the intended release of webhook verification functionality.
150-209
: Only formatting updates in thetypesVersions
block.
No changes to the actual paths or behavior—just expanded arrays for readability.packages/thirdweb/CHANGELOG.md (2)
3-6
: Changelog section formatting is consistent
The new version header (## 5.101.0
) and the### Minor Changes
subsection match the style of previous entries (e.g.,## 5.100.2
/### Patch Changes
).
7-13
: Verify commit and PR references
The entry lists PR [#7103] and the commit hashf3abea3…
for the webhook verification feature. Please double-check that these links point to the correct PR/commit and that the summary accurately reflects the upstream changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🔭 Outside diff range comments (1)
packages/wagmi-adapter/package.json (1)
35-39
: 🛠️ Refactor suggestionUpdate peerDependency for
thirdweb
ThepeerDependencies
field still pinsthirdweb
to^5.85.0
, which doesn’t cover the newly released5.101.0
. Consumers installing this adapter alongside the updated core package may encounter version conflicts. Consider updating the range to include the new version (e.g.,^5.101.0
).
🧹 Nitpick comments (2)
packages/wagmi-adapter/CHANGELOG.md (1)
3-4
: Add release notes for version 0.2.83
The new## 0.2.83
heading has no accompanying details. Please document any dependency bumps, bug fixes, or other changes introduced in this release for transparency.packages/thirdweb/CHANGELOG.md (1)
7-7
: Refine bullet formatting for consistency.The line nests two hyphens (
- [...]! - Added
) which can read awkwardly. Consider replacing the second hyphen with a colon or removing it for clearer style:-[#7103](https://github.com/thirdweb-dev/js/pull/7103) […]! - Added webhook verification functionality to securely verify incoming webhooks from thirdweb. +[#7103](https://github.com/thirdweb-dev/js/pull/7103) […]! Added webhook verification functionality to securely verify incoming webhooks from thirdweb.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
.changeset/webhook-verification.md
(0 hunks)packages/thirdweb/CHANGELOG.md
(1 hunks)packages/thirdweb/package.json
(2 hunks)packages/wagmi-adapter/CHANGELOG.md
(1 hunks)packages/wagmi-adapter/package.json
(1 hunks)
💤 Files with no reviewable changes (1)
- .changeset/webhook-verification.md
⏰ Context from checks skipped due to timeout of 90000ms (8)
- GitHub Check: E2E Tests (pnpm, esbuild)
- GitHub Check: E2E Tests (pnpm, webpack)
- GitHub Check: Unit Tests
- GitHub Check: Size
- GitHub Check: E2E Tests (pnpm, vite)
- GitHub Check: Lint Packages
- GitHub Check: Build Packages
- GitHub Check: Analyze (javascript)
🔇 Additional comments (4)
packages/wagmi-adapter/package.json (1)
3-3
: Bump package version
The version change from0.2.82
to0.2.83
aligns with the release process and looks good.packages/thirdweb/package.json (2)
3-3
: Approve version bump to 5.101.0
The package version has been correctly updated to 5.101.0 to match the new release.
149-210
: Approve cosmetic reformat oftypesVersions
The change expands single-line arrays into multi-line arrays for improved readability. This is purely formatting and has no functional impact.packages/thirdweb/CHANGELOG.md (1)
3-13
: Approve changelog update for version 5.101.0.The new section accurately documents the webhook verification feature, including detailed bullets and example usage, and adheres to the existing changelog structure.
size-limit report 📦
|
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
[email protected]
Minor Changes
#7103
f3abea3
Thanks @jnsdls! - Added webhook verification functionality to securely verify incoming webhooks from thirdweb. This includes:Webhook.parse
function to verify webhook signatures and timestampsx-payload-signature
andx-pay-signature
header formatsExample usage:
@thirdweb-dev/[email protected]
PR-Codex overview
This PR focuses on updating the versioning and changelogs for the
@thirdweb-dev/wagmi-adapter
andthirdweb
packages, while introducing new webhook verification functionality in thethirdweb
package.Detailed summary
@thirdweb-dev/wagmi-adapter
version from0.2.82
to0.2.83
.thirdweb
version5.101.0
:Webhook.parse
function for webhook verification.x-payload-signature
andx-pay-signature
headers.thirdweb
version from5.100.2
to5.101.0
.typesVersions
inthirdweb/package.json
for clarity.Summary by CodeRabbit
Documentation
Chores