Skip to content

chore: fix typos #7180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2025
Merged

chore: fix typos #7180

merged 1 commit into from
May 28, 2025

Conversation

joeybright53
Copy link
Contributor

@joeybright53 joeybright53 commented May 28, 2025

[SDK] Fix: Correct spelling errors in function names and comments

Notes for the reviewer

This PR fixes several spelling errors across the codebase:

  1. Fixed spelling in comment from "assumtion" to "assumption" in deploy-published.ts
  2. Corrected function name from "getTransactionsForMaketplaceV3" to "getTransactionsForMarketplaceV3" in get-required-transactions.ts
  3. Fixed spelling in comment from "assmeble" to "assemble" in process-override-list.ts

These changes ensure consistent and correct spelling throughout the codebase.

How to test

The changes are simple spelling corrections. No functional changes were made, so existing tests should continue to pass without modification.


PR-Codex overview

This PR focuses on correcting typos in comments and function names across several files in the thirdweb package to improve code clarity and maintainability.

Detailed summary

  • Fixed typo in comment: assmeble to assemble in process-override-list.ts.
  • Corrected typo in comment: asumption to assumption in deploy-published.ts.
  • Fixed typo in function name: getTransactionsForMaketplaceV3 to getTransactionsForMarketplaceV3 in get-required-transactions.ts.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

  • Bug Fixes

    • Corrected a typo in the function name for marketplace transactions to ensure consistency across the app.
  • Documentation

    • Fixed minor typos in code comments for improved clarity.

@joeybright53 joeybright53 requested review from a team as code owners May 28, 2025 06:10
Copy link

changeset-bot bot commented May 28, 2025

⚠️ No Changeset found

Latest commit: 485add3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

graphite-app bot commented May 28, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

Copy link

vercel bot commented May 28, 2025

@joeybright53 is attempting to deploy a commit to the thirdweb Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

coderabbitai bot commented May 28, 2025

Walkthrough

The changes consist solely of correcting typos in comments and function names across three files. No functional, logical, or control flow modifications were made. The only exported entity change is the renaming of a function to fix a spelling error.

Changes

File(s) Change Summary
packages/thirdweb/src/extensions/prebuilts/deploy-published.ts Fixed a comment typo: "asumption" → "assumption"
packages/thirdweb/src/extensions/prebuilts/get-required-transactions.ts Renamed function: "getTransactionsForMaketplaceV3" → "getTransactionsForMarketplaceV3" and updated its usage
packages/thirdweb/src/utils/extensions/drops/process-override-list.ts Fixed a comment typo: "assmeble" → "assemble"

Sequence Diagram(s)

No sequence diagram is generated as the changes are limited to typo corrections and function renaming, with no impact on control flow or feature logic.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e14a134 and 485add3.

📒 Files selected for processing (3)
  • packages/thirdweb/src/extensions/prebuilts/deploy-published.ts (1 hunks)
  • packages/thirdweb/src/extensions/prebuilts/get-required-transactions.ts (2 hunks)
  • packages/thirdweb/src/utils/extensions/drops/process-override-list.ts (1 hunks)
🔇 Additional comments (4)
packages/thirdweb/src/utils/extensions/drops/process-override-list.ts (1)

93-93: Typo fix approved. The comment typo has been corrected from "assmeble" to "assemble", improving readability without impacting functionality.

packages/thirdweb/src/extensions/prebuilts/deploy-published.ts (1)

311-311: Typo fix approved. The comment spelling has been corrected to "assumption". No changes to logic or behavior.

packages/thirdweb/src/extensions/prebuilts/get-required-transactions.ts (2)

143-143: Function rename approved. The call site has been updated to use getTransactionsForMarketplaceV3, fixing the previously misspelled function name.


176-176: Function definition rename approved. The function declaration is now correctly spelled as getTransactionsForMarketplaceV3 and matches its usage.

✨ Finishing Touches
  • 📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels May 28, 2025
@jnsdls jnsdls merged commit fd97406 into thirdweb-dev:main May 28, 2025
5 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages SDK Involves changes to the thirdweb SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants