Temporarily remove webhooks sidebar link until scrolling issue is fixed #7187
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
WalkthroughThe "Webhooks" sidebar link in the project dashboard was commented out, effectively removing it from the sidebar UI. The associated icon import was also removed. This change is temporary and is due to a scrolling issue, as indicated by an inline comment. Changes
Possibly related PRs
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (8)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7187 +/- ##
=======================================
Coverage 55.68% 55.68%
=======================================
Files 904 904
Lines 58404 58404
Branches 4126 4126
=======================================
Hits 32522 32522
Misses 25776 25776
Partials 106 106
🚀 New features to boost your workflow:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/components/ProjectSidebarLayout.tsx (1)
97-107: Consider adding a TODO or issue reference for better tracking.The temporary removal of the webhooks sidebar link is implemented correctly with a clear explanatory comment. However, consider adding a TODO comment or issue reference to ensure this gets properly tracked and resolved.
- // Commented until we solve the scrolling issue + // TODO: Uncomment once scrolling issue is fixed (Issue #XXX) + // Note: Remember to re-add BellIcon import when uncommentingAlso note that when this section is uncommented, you'll need to re-add the
BellIconimport:import { BookTextIcon, BoxIcon, + BellIcon, CoinsIcon, HomeIcon, SettingsIcon, WalletIcon, } from "lucide-react";
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/components/ProjectSidebarLayout.tsx(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (6)
- GitHub Check: E2E Tests (pnpm, esbuild)
- GitHub Check: Size
- GitHub Check: E2E Tests (pnpm, webpack)
- GitHub Check: Lint Packages
- GitHub Check: E2E Tests (pnpm, vite)
- GitHub Check: Analyze (javascript)
🔇 Additional comments (1)
apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/components/ProjectSidebarLayout.tsx (1)
4-11: LGTM! Clean removal of unused import.The removal of
BellIconimport is appropriate since it's no longer used after commenting out the webhooks section.
size-limit report 📦
|
Merge activity
|
…ed (#7187) ## [Dashboard] Fix: Temporarily remove Webhooks from sidebar ## Notes for the reviewer Commented out the Webhooks section in the project sidebar until we resolve a scrolling issue. Also removed the unused BellIcon import. ## How to test Verify that the Webhooks option no longer appears in the project sidebar navigation. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Bug Fixes** - Temporarily removed the "Webhooks" link from the project sidebar to address a scrolling issue. The link and its badge are no longer visible. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
graphite-app
bot
force-pushed
the
Temporarily_remove_webhooks_sidebar_link_until_scrolling_issue_is_fixed
branch
from
a6cc776 to
91750ed
Compare
graphite-app
bot
deleted the
Temporarily_remove_webhooks_sidebar_link_until_scrolling_issue_is_fixed
branch
[Dashboard] Fix: Temporarily remove Webhooks from sidebar
Notes for the reviewer
Commented out the Webhooks section in the project sidebar until we resolve a scrolling issue. Also removed the unused BellIcon import.
How to test
Verify that the Webhooks option no longer appears in the project sidebar navigation.
Summary by CodeRabbit
PR-Codex overview
This PR focuses on temporarily commenting out the
webhookssidebar link in theProjectSidebarLayoutcomponent to address a scrolling issue.Detailed summary
webhookssidebar link object in the array.href,label,icon, andtrackingproperties related to thewebhookslink.