Skip to content

Fix webhook dropdown scrolling by wrapping content in scrollable div #7199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

AmineAfia
Copy link
Contributor

@AmineAfia AmineAfia commented May 29, 2025


PR-Codex overview

This PR focuses on enhancing the FilterDetailsStep component by improving the handling of event and transaction signatures. It rebuilds the logic for selecting signatures and updates the user interface for better clarity and usability.

Detailed summary

  • Updated comment on Signature Hash Field to indicate rebuilding for both types.
  • Improved conditional rendering for event signatures.
  • Replaced checks for Object.keys(fetchedAbis) with direct checks on eventSignatures and functionSignatures arrays.
  • Simplified the structure of the Select components for better readability.
  • Added placeholders for fetching states in the Input components.
  • Used truncateMiddle for displaying function signatures in a consistent manner.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented May 29, 2025

⚠️ No Changeset found

Latest commit: 682e641

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented May 29, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 29, 2025 7:28pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) May 29, 2025 7:28pm
login ⬜️ Skipped (Inspect) May 29, 2025 7:28pm
thirdweb_playground ⬜️ Skipped (Inspect) May 29, 2025 7:28pm
wallet-ui ⬜️ Skipped (Inspect) May 29, 2025 7:28pm

Copy link
Contributor

coderabbitai bot commented May 29, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@vercel vercel bot temporarily deployed to Preview – wallet-ui May 29, 2025 13:53 Inactive
@vercel vercel bot temporarily deployed to Preview – login May 29, 2025 13:53 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 29, 2025 13:53 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 May 29, 2025 13:53 Inactive
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label May 29, 2025
Copy link
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codecov bot commented May 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.67%. Comparing base (e6a5fc4) to head (682e641).

Additional details and impacted files
@@                                   Coverage Diff                                    @@
##           Re-enable_webhooks_sidebar_link_in_project_dashboard    #7199      +/-   ##
========================================================================================
- Coverage                                                 55.68%   55.67%   -0.01%     
========================================================================================
  Files                                                       904      904              
  Lines                                                     58392    58391       -1     
  Branches                                                   4122     4119       -3     
========================================================================================
- Hits                                                      32516    32510       -6     
- Misses                                                    25770    25776       +6     
+ Partials                                                    106      105       -1     
Flag Coverage Δ
packages 55.67% <ø> (-0.01%) ⬇️

see 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

github-actions bot commented May 29, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 61.7 KB (0%) 1.3 s (0%) 205 ms (+167.7% 🔺) 1.5 s
thirdweb (cjs) 344.53 KB (0%) 6.9 s (0%) 583 ms (-3.16% 🔽) 7.5 s
thirdweb (minimal + tree-shaking) 5.69 KB (0%) 114 ms (0%) 60 ms (+1114.25% 🔺) 173 ms
thirdweb/chains (tree-shaking) 531 B (0%) 11 ms (0%) 15 ms (+625% 🔺) 26 ms
thirdweb/react (minimal + tree-shaking) 19.54 KB (0%) 391 ms (0%) 106 ms (+636.81% 🔺) 497 ms

@AmineAfia AmineAfia force-pushed the Fix_webhook_dropdown_scrolling_by_wrapping_content_in_scrollable_div branch from 0f2d53c to f19e19c Compare May 29, 2025 14:20
@vercel vercel bot temporarily deployed to Preview – docs-v2 May 29, 2025 14:20 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 29, 2025 14:20 Inactive
@vercel vercel bot temporarily deployed to Preview – login May 29, 2025 14:20 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 29, 2025 14:20 Inactive
@AmineAfia AmineAfia force-pushed the Fix_webhook_dropdown_scrolling_by_wrapping_content_in_scrollable_div branch from f19e19c to e2a99ef Compare May 29, 2025 14:38
@vercel vercel bot temporarily deployed to Preview – docs-v2 May 29, 2025 14:39 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 29, 2025 14:39 Inactive
@vercel vercel bot temporarily deployed to Preview – login May 29, 2025 14:39 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 29, 2025 14:39 Inactive
@AmineAfia AmineAfia force-pushed the Fix_webhook_dropdown_scrolling_by_wrapping_content_in_scrollable_div branch from e2a99ef to 4064df1 Compare May 29, 2025 14:54
@vercel vercel bot temporarily deployed to Preview – docs-v2 May 29, 2025 14:54 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 29, 2025 14:54 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 29, 2025 14:54 Inactive
@AmineAfia AmineAfia force-pushed the Fix_webhook_dropdown_scrolling_by_wrapping_content_in_scrollable_div branch from 4064df1 to e9faf5b Compare May 29, 2025 17:05
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 29, 2025 17:06 Inactive
@vercel vercel bot temporarily deployed to Preview – login May 29, 2025 17:06 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 29, 2025 17:06 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 May 29, 2025 17:06 Inactive
@AmineAfia AmineAfia force-pushed the Fix_webhook_dropdown_scrolling_by_wrapping_content_in_scrollable_div branch from e9faf5b to 834e69a Compare May 29, 2025 17:31
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 29, 2025 17:31 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 May 29, 2025 17:31 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 29, 2025 17:31 Inactive
@vercel vercel bot temporarily deployed to Preview – login May 29, 2025 17:31 Inactive
@AmineAfia AmineAfia force-pushed the Re-enable_webhooks_sidebar_link_in_project_dashboard branch from f3aebed to a58e480 Compare May 29, 2025 19:09
@AmineAfia AmineAfia force-pushed the Fix_webhook_dropdown_scrolling_by_wrapping_content_in_scrollable_div branch from 834e69a to dd9eefc Compare May 29, 2025 19:09
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 29, 2025 19:09 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 29, 2025 19:09 Inactive
@vercel vercel bot temporarily deployed to Preview – login May 29, 2025 19:09 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 May 29, 2025 19:09 Inactive
@AmineAfia AmineAfia force-pushed the Re-enable_webhooks_sidebar_link_in_project_dashboard branch from a58e480 to e6a5fc4 Compare May 29, 2025 19:21
@AmineAfia AmineAfia force-pushed the Fix_webhook_dropdown_scrolling_by_wrapping_content_in_scrollable_div branch from dd9eefc to 682e641 Compare May 29, 2025 19:21
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 29, 2025 19:21 Inactive
@vercel vercel bot temporarily deployed to Preview – login May 29, 2025 19:21 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 29, 2025 19:21 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 May 29, 2025 19:21 Inactive
@AmineAfia AmineAfia closed this May 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant