chore: remove Team from confirmEmail response #7200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
|
Warning Rate limit exceeded@graphite-app[bot] has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 4 minutes and 3 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (4)
WalkthroughThe changes remove all references to the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant VerifyEmailComponent
participant API
User->>VerifyEmailComponent: Submit confirmation token
VerifyEmailComponent->>API: verifyEmail({ confirmationToken })
API-->>VerifyEmailComponent: { account }
VerifyEmailComponent->>ParentComponent: onEmailConfirmed({ account })
sequenceDiagram
participant ParentComponent
participant AccountOnboarding
participant API
ParentComponent->>AccountOnboarding: Start onboarding
AccountOnboarding->>API: verifyEmail({ confirmationToken })
API-->>AccountOnboarding: { account }
AccountOnboarding->>ParentComponent: onComplete({ account })
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7200 +/- ##
==========================================
+ Coverage 55.63% 55.65% +0.01%
==========================================
Files 908 908
Lines 58546 58546
Branches 4129 4130 +1
==========================================
+ Hits 32573 32582 +9
+ Misses 25868 25858 -10
- Partials 105 106 +1
🚀 New features to boost your workflow:
|
size-limit report 📦
|
jnsdls
approved these changes
May 29, 2025
Merge activity
|
graphite-app bot
pushed a commit
that referenced
this pull request
May 30, 2025
<!-- start pr-codex -->
## PR-Codex overview
This PR focuses on removing the `Team` type from several components and functions related to email verification and onboarding, simplifying the data structure by only handling the `Account` type.
### Detailed summary
- Removed `teamStub` usage in `VerifyEmail.stories.tsx`.
- Updated `useUpdateNotifications` to remove `team` from the response data type.
- Modified `VerifyEmailProps` to exclude `team` in `onEmailConfirmed` and `verifyEmail`.
- Adjusted `AccountOnboardingProps` to remove `team` in `onComplete` and `verifyEmail`.
- Simplified `onEmailConfirmed` callback in `AccountOnboardingUI`.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
<!-- This is an auto-generated comment: release notes by coderabbit.ai -->
## Summary by CodeRabbit
- **Refactor**
- Simplified onboarding and email verification flows by removing the requirement for team-related data. All relevant callbacks and functions now operate solely with account information.
- **Type Updates**
- Updated type signatures for onboarding and verification handlers to exclude the team property, streamlining integration for end-users and developers.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
graphite-app
bot
force-pushed
the
ph/remove-team-from-confirmEmail-response
branch
from
7ac54a4 to
9d62cf5
Compare
graphite-app bot
pushed a commit
that referenced
this pull request
May 30, 2025
<!-- start pr-codex -->
## PR-Codex overview
This PR focuses on simplifying the data structure by removing the `team` object from various components and functions related to email verification and account onboarding, streamlining the code for better clarity and maintenance.
### Detailed summary
- Removed `team` from the `onEmailConfirmed` callback in `VerifyEmailProps`.
- Updated `verifyEmail` function to return only `account` instead of both `team` and `account`.
- Adjusted the `onComplete` prop in `AccountOnboardingProps` to accept only `account`.
- Eliminated `team` type import from relevant files.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
<!-- This is an auto-generated comment: release notes by coderabbit.ai -->
## Summary by CodeRabbit
- **Refactor**
- Simplified onboarding and email verification flows by removing the requirement for team-related data. All relevant callbacks and functions now operate solely with account information.
- **Type Updates**
- Updated type signatures for onboarding and verification handlers to exclude the team property, streamlining integration for end-users and developers.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
graphite-app
bot
force-pushed
the
ph/remove-team-from-confirmEmail-response
branch
from
9d62cf5 to
1f7d47e
Compare
<!-- start pr-codex -->
## PR-Codex overview
This PR focuses on removing references to `Team` in various components related to email verification and onboarding, simplifying the data structure passed around.
### Detailed summary
- Removed `teamStub` import and related references in `VerifyEmail.stories.tsx`.
- Eliminated `Team` type imports in `useApi.ts`, `VerifyEmail.tsx`, and `account-onboarding-ui.tsx`.
- Updated `onEmailConfirmed` and `verifyEmail` props to only handle `account` in `VerifyEmail.tsx` and `account-onboarding-ui.tsx`.
- Adjusted the `onComplete` prop in `AccountOnboardingProps` to reflect the removal of `team`.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
<!-- This is an auto-generated comment: release notes by coderabbit.ai -->
## Summary by CodeRabbit
- **Refactor**
- Simplified onboarding and email verification flows by removing the requirement for team-related data. All relevant callbacks and functions now operate solely with account information.
- **Type Updates**
- Updated type signatures for onboarding and verification handlers to exclude the team property, streamlining integration for end-users and developers.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
graphite-app
bot
force-pushed
the
ph/remove-team-from-confirmEmail-response
branch
from
1f7d47e to
ac4ade6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR focuses on removing the dependency on the
Teamtype across various components related to email verification, simplifying the data structures used in the onboarding process.Detailed summary
teamStubimport inVerifyEmail.stories.tsx.Teamtype usage inuseApi.ts,VerifyEmail.tsx, andaccount-onboarding-ui.tsx.onEmailConfirmedandverifyEmailprops to only includeaccountinstead of bothaccountandteam.onCompletecallback inAccountOnboardingUIto directly useprops.onComplete.Summary by CodeRabbit