Skip to content

[Dashboard] Fix Stripe balance calculation in getStripeBalance function #7269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jnsdls
Copy link
Member

@jnsdls jnsdls commented Jun 4, 2025

TL;DR

Fixed Stripe balance calculation to correctly convert from cents to dollars.

What changed?

Modified the getStripeBalance function to divide the customer balance by -100 instead of multiplying by -1. This properly converts the Stripe balance from cents to dollars.

How to test?

  1. Create or use an existing Stripe customer with a non-zero balance
  2. Call the getStripeBalance function with the customer ID
  3. Verify that the returned balance is correctly displayed as dollars (e.g., a balance of 1000 cents should return 10 dollars)

Why make this change?

Stripe stores monetary values in the smallest currency unit (cents for USD). The previous implementation incorrectly handled this by only inverting the sign, but not converting from cents to dollars. This fix ensures that balances are displayed in the correct currency format for users.


PR-Codex overview

This PR updates the balance calculation in the stripe-actions.ts file to correct how the balance is derived from Stripe's API. It changes the operation from multiplication by -1 to division by -100 to accurately reflect the customer's balance.

Detailed summary

  • Changed the comment to clarify the new calculation method for the balance.
  • Updated the return statement from customer.balance * -1 to customer.balance / -100 for accurate balance conversion.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

  • Bug Fixes
    • Corrected the calculation of Stripe customer balances to display accurate values.

@vercel vercel bot temporarily deployed to Preview – login June 4, 2025 05:35 Inactive
Copy link

vercel bot commented Jun 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 4, 2025 5:49am
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Jun 4, 2025 5:49am
login ⬜️ Skipped (Inspect) Jun 4, 2025 5:49am
thirdweb_playground ⬜️ Skipped (Inspect) Jun 4, 2025 5:49am
wallet-ui ⬜️ Skipped (Inspect) Jun 4, 2025 5:49am

Copy link

changeset-bot bot commented Jun 4, 2025

⚠️ No Changeset found

Latest commit: ae3014a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – docs-v2 June 4, 2025 05:35 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground June 4, 2025 05:35 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui June 4, 2025 05:35 Inactive
Copy link
Contributor

coderabbitai bot commented Jun 4, 2025

Walkthrough

The getStripeBalance function in stripe-actions.ts was updated to change the method of converting a customer's Stripe balance. Instead of negating the balance, the function now divides the balance by -100 to obtain the actual value, with corresponding updates to the code comment.

Changes

File(s) Change Summary
apps/dashboard/src/@/actions/stripe-actions.ts Modified getStripeBalance to convert Stripe balance by dividing by -100 instead of multiplying by -1.

Possibly related PRs


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4edf1eb and ae3014a.

📒 Files selected for processing (1)
  • apps/dashboard/src/@/actions/stripe-actions.ts (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (7)
  • GitHub Check: E2E Tests (pnpm, esbuild)
  • GitHub Check: Size
  • GitHub Check: E2E Tests (pnpm, webpack)
  • GitHub Check: Lint Packages
  • GitHub Check: E2E Tests (pnpm, vite)
  • GitHub Check: Unit Tests
  • GitHub Check: Analyze (javascript)
🔇 Additional comments (1)
apps/dashboard/src/@/actions/stripe-actions.ts (1)

72-73: LGTM! Correct currency conversion from Stripe's cent-based API.

The fix properly converts Stripe's balance from cents to dollars. Stripe API returns balances in the smallest currency unit (cents), so dividing by -100 both converts to dollars and handles the sign appropriately. The previous implementation was missing this essential currency conversion.

✨ Finishing Touches
  • 📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Jun 4, 2025
Copy link
Member Author

jnsdls commented Jun 4, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@jnsdls jnsdls marked this pull request as ready for review June 4, 2025 05:35
@jnsdls jnsdls requested review from a team as code owners June 4, 2025 05:35
@jnsdls jnsdls force-pushed the _Dashboard_Fix_Stripe_balance_calculation_in_getStripeBalance_function branch from 6ae607e to ae3014a Compare June 4, 2025 05:36
@vercel vercel bot temporarily deployed to Preview – wallet-ui June 4, 2025 05:36 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground June 4, 2025 05:36 Inactive
@vercel vercel bot temporarily deployed to Preview – login June 4, 2025 05:36 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 June 4, 2025 05:36 Inactive
Copy link

codecov bot commented Jun 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.57%. Comparing base (4edf1eb) to head (ae3014a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7269   +/-   ##
=======================================
  Coverage   55.57%   55.57%           
=======================================
  Files         909      909           
  Lines       58681    58681           
  Branches     4167     4167           
=======================================
  Hits        32612    32612           
  Misses      25961    25961           
  Partials      108      108           
Flag Coverage Δ
packages 55.57% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

github-actions bot commented Jun 4, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 62.57 KB (0%) 1.3 s (0%) 389 ms (+88.31% 🔺) 1.7 s
thirdweb (cjs) 345.38 KB (0%) 7 s (0%) 1.6 s (+0.27% 🔺) 8.5 s
thirdweb (minimal + tree-shaking) 5.7 KB (0%) 114 ms (0%) 86 ms (+706.14% 🔺) 200 ms
thirdweb/chains (tree-shaking) 531 B (0%) 11 ms (0%) 27 ms (+376.2% 🔺) 38 ms
thirdweb/react (minimal + tree-shaking) 19.56 KB (0%) 392 ms (0%) 120 ms (+310.42% 🔺) 511 ms

@jnsdls jnsdls merged commit d4bc8e1 into main Jun 4, 2025
23 of 24 checks passed
@jnsdls jnsdls deleted the _Dashboard_Fix_Stripe_balance_calculation_in_getStripeBalance_function branch June 4, 2025 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant