-
Notifications
You must be signed in to change notification settings - Fork 559
Dashboard: remove date selector from UB FTUX, improved skeletons #7435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dashboard: remove date selector from UB FTUX, improved skeletons #7435
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
WalkthroughThe Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Page
participant PayAnalytics
participant ResponsiveSuspense
participant PayAnalyticsFilter
participant Skeleton
User->>Page: Load analytics page
Page->>PayAnalytics: Render PayAnalytics
PayAnalytics->>PayAnalyticsFilter: Render filter UI
PayAnalytics->>ResponsiveSuspense: Wrap analytics content
ResponsiveSuspense->>Skeleton: Show skeletons while loading
ResponsiveSuspense->>PayAnalytics: Render analytics content when ready
Possibly related PRs
Suggested reviewers
Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (1)
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (3)
💤 Files with no reviewable changes (1)
🚧 Files skipped from review as they are similar to previous changes (2)
⏰ Context from checks skipped due to timeout of 90000ms (8)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7435 +/- ##
=======================================
Coverage 51.96% 51.96%
=======================================
Files 947 947
Lines 63809 63809
Branches 4216 4216
=======================================
Hits 33161 33161
Misses 30542 30542
Partials 106 106
🚀 New features to boost your workflow:
|
size-limit report 📦
|
Merge activity
|
<!-- ## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes" If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000): ## Notes for the reviewer Anything important to call out? Be sure to also clarify these in your comments. ## How to test Unit tests, playground, etc. --> <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on refactoring the `Page` component in the `loading.tsx` file and the `PayAnalytics` component in the `PayAnalytics.tsx` file, enhancing the structure and user experience by modifying the rendering of analytics and loading states. ### Detailed summary - Removed `ResponsiveSuspense` and `PayAnalyticsFilter` from `loading.tsx`. - Integrated `PayAnalytics` directly into the `Page` component. - Added `ResponsiveSuspense` with a skeleton loader in `PayAnalytics`. - Reorganized analytics display in `PayAnalytics`, including filtering and layout adjustments. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Improved the loading experience in the PayAnalytics section with responsive skeleton placeholders during data loading. - Updated the layout to display analytics filters above the loading state for better usability. - **Chores** - Removed unused loading and suspense logic from related pages to streamline the user interface. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
af46ddd
to
8bb4d4b
Compare
PR-Codex overview
This PR focuses on refactoring the
Page
component and thePayAnalytics
component by removing unnecessary elements, optimizing the loading state, and enhancing the layout with new loading indicators.Detailed summary
ResponsiveSuspense
andPayAnalyticsFilter
from thePage
component.PayAnalytics
component structure.Skeleton
loading indicator for better user feedback.Summary by CodeRabbit
Refactor
Chores