Skip to content

Add CLAUDE.md #7438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged

Conversation

joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Jun 25, 2025


PR-Codex overview

This PR adds a comprehensive CLAUDE.md file that outlines development commands, repository architecture, development practices, contribution workflow, release testing, and multi-platform support for the project.

Detailed summary

  • Introduced CLAUDE.md for project guidance.
  • Detailed development commands for package management, building, testing, and code quality.
  • Explained repository architecture and monorepo structure.
  • Outlined GitHub workflow, code quality standards, and TypeScript guidelines.
  • Provided testing strategies and SDK development practices.
  • Established contribution workflow and changeset guidelines.
  • Documented multi-platform support for Web, React Native, and Node.js.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Jun 25, 2025

⚠️ No Changeset found

Latest commit: ba90e20

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

coderabbitai bot commented Jun 25, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

vercel bot commented Jun 25, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 25, 2025 1:32am
nebula ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 25, 2025 1:32am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 25, 2025 1:32am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 25, 2025 1:32am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 25, 2025 1:32am

@joaquim-verges joaquim-verges marked this pull request as ready for review June 25, 2025 01:25
Copy link
Member Author

joaquim-verges commented Jun 25, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 62.56 KB (0%) 1.3 s (0%) 263 ms (+72.37% 🔺) 1.6 s
thirdweb (cjs) 350.74 KB (0%) 7.1 s (0%) 1.2 s (-5.01% 🔽) 8.2 s
thirdweb (minimal + tree-shaking) 5.72 KB (0%) 115 ms (0%) 95 ms (+901.56% 🔺) 209 ms
thirdweb/chains (tree-shaking) 530 B (0%) 11 ms (0%) 33 ms (+499.26% 🔺) 43 ms
thirdweb/react (minimal + tree-shaking) 19.61 KB (0%) 393 ms (0%) 83 ms (+201.22% 🔺) 475 ms

Copy link

codecov bot commented Jun 25, 2025

Codecov Report

Attention: Patch coverage is 16.66667% with 10 lines in your changes missing coverage. Please review.

Project coverage is 51.96%. Comparing base (d85ee5f) to head (ba90e20).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...dweb/src/react/core/hooks/useTransactionDetails.ts 14.28% 6 Missing ⚠️
...web/src/react/web/ui/Bridge/TransactionPayment.tsx 33.33% 2 Missing ⚠️
.../web/ui/Bridge/payment-details/PaymentOverview.tsx 0.00% 2 Missing ⚠️

❌ Your patch status has failed because the patch coverage (16.66%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7438      +/-   ##
==========================================
- Coverage   51.96%   51.96%   -0.01%     
==========================================
  Files         947      947              
  Lines       63809    63820      +11     
  Branches     4216     4214       -2     
==========================================
+ Hits        33161    33163       +2     
- Misses      30542    30551       +9     
  Partials      106      106              
Flag Coverage Δ
packages 51.96% <16.66%> (-0.01%) ⬇️
Files with missing lines Coverage Δ
...web/src/react/web/ui/Bridge/TransactionPayment.tsx 6.46% <33.33%> (+0.27%) ⬆️
.../web/ui/Bridge/payment-details/PaymentOverview.tsx 5.13% <0.00%> (-0.05%) ⬇️
...dweb/src/react/core/hooks/useTransactionDetails.ts 11.45% <14.28%> (+0.25%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Base automatically changed from Handle_sponsored_gas_on_TransactionWidget to main June 25, 2025 02:10
@joaquim-verges joaquim-verges requested review from a team as code owners June 25, 2025 02:10
@joaquim-verges joaquim-verges merged commit 830125c into main Jun 25, 2025
25 checks passed
@joaquim-verges joaquim-verges deleted the Add_CLAUDE.md_for_repository_development_guidance branch June 25, 2025 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant