Skip to content

[Playground] Update product details from hoodie to concert ticket #7473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Jun 29, 2025


PR-Codex overview

This PR focuses on updating the ConnectEmbed component and related files to reflect a new product offering, changing descriptions and images associated with a concert ticket instead of a hoodie.

Detailed summary

  • In ConnectEmbed.tsx, the border styling was removed.
  • In page.tsx:
    • Changed name from "Black Hoodie" to "Concert Ticket".
    • Updated image to a concert ticket URL.
    • Changed description to "Concert ticket for the upcoming show".
  • In direct-payment.tsx:
    • Updated description to "Get your ticket for The Midnight Live".
    • Changed image to a new URL for the concert ticket.
    • Updated name to "Concert Ticket".

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

  • New Features

    • Updated product details in the checkout experience to feature a "Concert Ticket" with a new image and description.
  • Style

    • Removed the border around the embed container for a cleaner visual appearance.

Copy link

vercel bot commented Jun 29, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 29, 2025 10:40pm
nebula ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 29, 2025 10:40pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 29, 2025 10:40pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 29, 2025 10:40pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 29, 2025 10:40pm

Copy link

changeset-bot bot commented Jun 29, 2025

⚠️ No Changeset found

Latest commit: e7335b0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

coderabbitai bot commented Jun 29, 2025

Walkthrough

This update modifies product metadata in two components, changing the product name, description, and image from a hoodie to a concert ticket. Additionally, a border style is removed from a styled container in the ConnectWallet modal. No changes to logic, exported entities, or control flow are present.

Changes

File(s) Change Summary
apps/playground-web/src/app/connect/pay/commerce/page.tsx Updated product name, description, and image in the BuyMerch example from hoodie to concert ticket.
apps/playground-web/src/components/pay/direct-payment.tsx Changed product details and image in BuyMerchPreview from hoodie to concert ticket.
packages/thirdweb/src/react/web/ui/ConnectWallet/Modal/ConnectEmbed.tsx Removed the border style from the EmbedContainer styled component.

Sequence Diagram(s)

No sequence diagram generated as the changes are limited to static metadata and styling updates.

Possibly related PRs

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)
  • TEAM-0000: Entity not found: Issue - Could not find referenced Issue.
✨ Finishing Touches
  • 📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added Playground Changes involving the Playground codebase. packages SDK Involves changes to the thirdweb SDK labels Jun 29, 2025
@joaquim-verges joaquim-verges changed the title [Pay] Update product details from hoodie to concert ticket [Playground] Update product details from hoodie to concert ticket Jun 29, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@joaquim-verges joaquim-verges marked this pull request as ready for review June 29, 2025 22:24
@joaquim-verges joaquim-verges requested review from a team as code owners June 29, 2025 22:24
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (3)
apps/playground-web/src/app/connect/pay/commerce/page.tsx (2)

49-51: Use a real image URL & keep it consistent with the preview component

https://example.com/concert-ticket.jpg is clearly a placeholder and will almost certainly 404 in real-world usage.
Since the preview component already uses an Unsplash image, consider pointing to the same (or any other reachable) asset here to avoid broken thumbnails and keep the docs snippet aligned.

-        image="https://example.com/concert-ticket.jpg"
+        image="https://images.unsplash.com/photo-1501281668745-f7f57925c3b4?w=500&h=300&fit=crop"

1-3: Minor: mark the route file as server-only

This page component is implicitly a Server Component.
Adding import "server-only"; up-top follows the house guideline and protects against accidental client imports, at zero runtime cost.

+import "server-only";
 import type { Metadata } from "next";
 import { PageLayout } from "@/components/blocks/APIHeader";
apps/playground-web/src/components/pay/direct-payment.tsx (1)

6-17: Rename BuyMerchPreview to better reflect the new product

The function name and surrounding wording (“Merch”) no longer match the concert-ticket example that’s shown.
Renaming avoids confusion for readers skimming the code or searching for “ticket” examples later.

-export function BuyMerchPreview() {
+export function BuyTicketPreview() {
@@
-      <CheckoutWidget
+      <CheckoutWidget

Remember to update all imports (<BuyMerchPreview />, etc.) correspondingly.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fd67c5d and e7335b0.

📒 Files selected for processing (3)
  • apps/playground-web/src/app/connect/pay/commerce/page.tsx (1 hunks)
  • apps/playground-web/src/components/pay/direct-payment.tsx (1 hunks)
  • packages/thirdweb/src/react/web/ui/ConnectWallet/Modal/ConnectEmbed.tsx (0 hunks)
💤 Files with no reviewable changes (1)
  • packages/thirdweb/src/react/web/ui/ConnectWallet/Modal/ConnectEmbed.tsx
🧰 Additional context used
📓 Path-based instructions (1)
`**/*.@(ts|tsx)`: Accept a typed 'props' object and export a named function (e.g...

**/*.@(ts|tsx): Accept a typed 'props' object and export a named function (e.g., export function MyComponent()).
Combine class names via 'cn', expose 'className' prop if useful.
Reuse core UI primitives; avoid re-implementing buttons, cards, modals.
Local state or effects live inside; data fetching happens in hooks.
Merge class names with 'cn' from '@/lib/utils' to keep conditional logic readable.
Stick to design-tokens: background ('bg-card'), borders ('border-border'), muted text ('text-muted-foreground') etc.
Use the 'container' class with a 'max-w-7xl' cap for page width consistency.
Spacing utilities ('px-', 'py-', 'gap-*') are preferred over custom margins.
Responsive helpers follow mobile-first ('max-sm', 'md', 'lg', 'xl').
Never hard-code colors – always go through Tailwind variables.
Tailwind CSS is the styling system – avoid inline styles or CSS modules.
Prefix files with 'import "server-only";' so they never end up in the client bundle (for server-only code).

📄 Source: CodeRabbit Inference Engine (.cursor/rules/dashboard.mdc)

List of files the instruction was applied to:

  • apps/playground-web/src/app/connect/pay/commerce/page.tsx
  • apps/playground-web/src/components/pay/direct-payment.tsx
🧠 Learnings (2)
📓 Common learnings
Learnt from: MananTank
PR: thirdweb-dev/js#7315
File: apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/assets/create/nft/launch-nft.tsx:153-226
Timestamp: 2025-06-10T00:50:20.795Z
Learning: In apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/assets/create/nft/launch-nft.tsx, the updateStatus function correctly expects a complete MultiStepState["status"] object. For pending states, { type: "pending" } is the entire status object. For error states, { type: "error", message: React.ReactNode } is the entire status object. The current code incorrectly spreads the entire step object instead of passing just the status object.
apps/playground-web/src/components/pay/direct-payment.tsx (2)
Learnt from: MananTank
PR: thirdweb-dev/js#7152
File: apps/dashboard/src/app/(app)/(dashboard)/(chain)/[chain_id]/[contractAddress]/(marketplace)/direct-listings/shared-direct-listings-page.tsx:47-52
Timestamp: 2025-05-26T16:29:54.317Z
Learning: The `projectMeta` prop is not required for the server-rendered `ContractDirectListingsPage` component in the direct listings shared page, following the same pattern as other server components in the codebase where `projectMeta` is only needed for client components.
Learnt from: MananTank
PR: thirdweb-dev/js#7177
File: apps/dashboard/src/app/(app)/(dashboard)/(chain)/[chain_id]/[contractAddress]/public-pages/erc20/_hooks/useTokenPriceData.ts:49-49
Timestamp: 2025-05-27T19:55:25.056Z
Learning: In the ERC20 public pages token price data hook (`useTokenPriceData.ts`), direct array access on `json.data[0]` without optional chaining is intentionally correct and should not be changed to use safety checks.
⏰ Context from checks skipped due to timeout of 90000ms (8)
  • GitHub Check: Size
  • GitHub Check: E2E Tests (pnpm, esbuild)
  • GitHub Check: E2E Tests (pnpm, webpack)
  • GitHub Check: Unit Tests
  • GitHub Check: Build Packages
  • GitHub Check: E2E Tests (pnpm, vite)
  • GitHub Check: Lint Packages
  • GitHub Check: Analyze (javascript)

Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 63.11 KB (0%) 1.3 s (0%) 316 ms (+153.18% 🔺) 1.6 s
thirdweb (cjs) 352.76 KB (0%) 7.1 s (0%) 948 ms (+13.8% 🔺) 8.1 s
thirdweb (minimal + tree-shaking) 5.72 KB (0%) 115 ms (0%) 124 ms (+1574.26% 🔺) 238 ms
thirdweb/chains (tree-shaking) 530 B (0%) 11 ms (0%) 51 ms (+2110.05% 🔺) 61 ms
thirdweb/react (minimal + tree-shaking) 19.59 KB (0%) 392 ms (0%) 148 ms (+703.12% 🔺) 539 ms

@joaquim-verges joaquim-verges merged commit 85a5037 into main Jun 30, 2025
23 of 24 checks passed
@joaquim-verges joaquim-verges deleted the _Pay_Update_product_details_from_hoodie_to_concert_ticket branch June 30, 2025 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages Playground Changes involving the Playground codebase. SDK Involves changes to the thirdweb SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant