-
Notifications
You must be signed in to change notification settings - Fork 559
[Playground] Update product details from hoodie to concert ticket #7473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Playground] Update product details from hoodie to concert ticket #7473
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
WalkthroughThis update modifies product metadata in two components, changing the product name, description, and image from a hoodie to a concert ticket. Additionally, a border style is removed from a styled container in the ConnectWallet modal. No changes to logic, exported entities, or control flow are present. Changes
Sequence Diagram(s)No sequence diagram generated as the changes are limited to static metadata and styling updates. Possibly related PRs
Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (1)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (3)
apps/playground-web/src/app/connect/pay/commerce/page.tsx (2)
49-51
: Use a real image URL & keep it consistent with the preview component
https://example.com/concert-ticket.jpg
is clearly a placeholder and will almost certainly 404 in real-world usage.
Since the preview component already uses an Unsplash image, consider pointing to the same (or any other reachable) asset here to avoid broken thumbnails and keep the docs snippet aligned.- image="https://example.com/concert-ticket.jpg" + image="https://images.unsplash.com/photo-1501281668745-f7f57925c3b4?w=500&h=300&fit=crop"
1-3
: Minor: mark the route file as server-onlyThis page component is implicitly a Server Component.
Addingimport "server-only";
up-top follows the house guideline and protects against accidental client imports, at zero runtime cost.+import "server-only"; import type { Metadata } from "next"; import { PageLayout } from "@/components/blocks/APIHeader";
apps/playground-web/src/components/pay/direct-payment.tsx (1)
6-17
: RenameBuyMerchPreview
to better reflect the new productThe function name and surrounding wording (“Merch”) no longer match the concert-ticket example that’s shown.
Renaming avoids confusion for readers skimming the code or searching for “ticket” examples later.-export function BuyMerchPreview() { +export function BuyTicketPreview() { @@ - <CheckoutWidget + <CheckoutWidgetRemember to update all imports (
<BuyMerchPreview />
, etc.) correspondingly.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
apps/playground-web/src/app/connect/pay/commerce/page.tsx
(1 hunks)apps/playground-web/src/components/pay/direct-payment.tsx
(1 hunks)packages/thirdweb/src/react/web/ui/ConnectWallet/Modal/ConnectEmbed.tsx
(0 hunks)
💤 Files with no reviewable changes (1)
- packages/thirdweb/src/react/web/ui/ConnectWallet/Modal/ConnectEmbed.tsx
🧰 Additional context used
📓 Path-based instructions (1)
`**/*.@(ts|tsx)`: Accept a typed 'props' object and export a named function (e.g...
**/*.@(ts|tsx)
: Accept a typed 'props' object and export a named function (e.g., export function MyComponent()).
Combine class names via 'cn', expose 'className' prop if useful.
Reuse core UI primitives; avoid re-implementing buttons, cards, modals.
Local state or effects live inside; data fetching happens in hooks.
Merge class names with 'cn' from '@/lib/utils' to keep conditional logic readable.
Stick to design-tokens: background ('bg-card'), borders ('border-border'), muted text ('text-muted-foreground') etc.
Use the 'container' class with a 'max-w-7xl' cap for page width consistency.
Spacing utilities ('px-', 'py-', 'gap-*') are preferred over custom margins.
Responsive helpers follow mobile-first ('max-sm', 'md', 'lg', 'xl').
Never hard-code colors – always go through Tailwind variables.
Tailwind CSS is the styling system – avoid inline styles or CSS modules.
Prefix files with 'import "server-only";' so they never end up in the client bundle (for server-only code).
📄 Source: CodeRabbit Inference Engine (.cursor/rules/dashboard.mdc)
List of files the instruction was applied to:
apps/playground-web/src/app/connect/pay/commerce/page.tsx
apps/playground-web/src/components/pay/direct-payment.tsx
🧠 Learnings (2)
📓 Common learnings
Learnt from: MananTank
PR: thirdweb-dev/js#7315
File: apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/assets/create/nft/launch-nft.tsx:153-226
Timestamp: 2025-06-10T00:50:20.795Z
Learning: In apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/assets/create/nft/launch-nft.tsx, the updateStatus function correctly expects a complete MultiStepState["status"] object. For pending states, { type: "pending" } is the entire status object. For error states, { type: "error", message: React.ReactNode } is the entire status object. The current code incorrectly spreads the entire step object instead of passing just the status object.
apps/playground-web/src/components/pay/direct-payment.tsx (2)
Learnt from: MananTank
PR: thirdweb-dev/js#7152
File: apps/dashboard/src/app/(app)/(dashboard)/(chain)/[chain_id]/[contractAddress]/(marketplace)/direct-listings/shared-direct-listings-page.tsx:47-52
Timestamp: 2025-05-26T16:29:54.317Z
Learning: The `projectMeta` prop is not required for the server-rendered `ContractDirectListingsPage` component in the direct listings shared page, following the same pattern as other server components in the codebase where `projectMeta` is only needed for client components.
Learnt from: MananTank
PR: thirdweb-dev/js#7177
File: apps/dashboard/src/app/(app)/(dashboard)/(chain)/[chain_id]/[contractAddress]/public-pages/erc20/_hooks/useTokenPriceData.ts:49-49
Timestamp: 2025-05-27T19:55:25.056Z
Learning: In the ERC20 public pages token price data hook (`useTokenPriceData.ts`), direct array access on `json.data[0]` without optional chaining is intentionally correct and should not be changed to use safety checks.
⏰ Context from checks skipped due to timeout of 90000ms (8)
- GitHub Check: Size
- GitHub Check: E2E Tests (pnpm, esbuild)
- GitHub Check: E2E Tests (pnpm, webpack)
- GitHub Check: Unit Tests
- GitHub Check: Build Packages
- GitHub Check: E2E Tests (pnpm, vite)
- GitHub Check: Lint Packages
- GitHub Check: Analyze (javascript)
size-limit report 📦
|
PR-Codex overview
This PR focuses on updating the
ConnectEmbed
component and related files to reflect a new product offering, changing descriptions and images associated with a concert ticket instead of a hoodie.Detailed summary
ConnectEmbed.tsx
, the border styling was removed.page.tsx
:name
from "Black Hoodie" to "Concert Ticket".image
to a concert ticket URL.description
to "Concert ticket for the upcoming show".direct-payment.tsx
:description
to "Get your ticket for The Midnight Live".image
to a new URL for the concert ticket.name
to "Concert Ticket".Summary by CodeRabbit
New Features
Style