Dashboard: Add missing asset creation successs tracking for nft #7494

MananTank · 2025-07-01T18:03:45Z

PR-Codex overview

This PR enhances the launch-nft.tsx file by adding a new analytics reporting function for successful NFT asset creation, improving tracking of asset launches.

Detailed summary

Added import for reportAssetCreationSuccessful from the analytics module.
Implemented a call to reportAssetCreationSuccessful with parameters for assetType and contractType upon successful NFT launch.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

New Features
- Added a success reporting step after completing the NFT launch process, providing improved feedback for successful NFT creation.

vercel · 2025-07-01T18:03:47Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
thirdweb-www	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 1, 2025 8:08pm

4 Skipped Deployments

Name	Status	Updated (UTC)
docs-v2	⬜️ Skipped (Inspect)	Jul 1, 2025 8:08pm
nebula	⬜️ Skipped (Inspect)	Jul 1, 2025 8:08pm
thirdweb_playground	⬜️ Skipped (Inspect)	Jul 1, 2025 8:08pm
wallet-ui	⬜️ Skipped (Inspect)	Jul 1, 2025 8:08pm

coderabbitai · 2025-07-01T18:03:52Z

Walkthrough

A call to the reportAssetCreationSuccessful function is added after the successful completion of all steps in the NFT launch process within the executeSteps function. The function is invoked with the asset type "nft" and the contract type based on the ERC standard. The relevant import is also added.

Changes

File(s)	Change Summary
apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/tokens/create/nft/launch/launch-nft.tsx	Added import and invocation of `reportAssetCreationSuccessful` after successful NFT launch steps.

Possibly related PRs

posthog migration part 6 #7374: Introduces and refactors analytics reporting functions, including reportAssetCreationSuccessful, which is now used in the NFT launch process.

Suggested reviewers

jnsdls

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)

TEAM-0000: Entity not found: Issue - Could not find referenced Issue.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c07755c and 030c522.

📒 Files selected for processing (1)

apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/tokens/create/nft/launch/launch-nft.tsx (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/tokens/create/nft/launch/launch-nft.tsx

⏰ Context from checks skipped due to timeout of 90000ms (8)

GitHub Check: E2E Tests (pnpm, esbuild)
GitHub Check: E2E Tests (pnpm, webpack)
GitHub Check: E2E Tests (pnpm, vite)
GitHub Check: Unit Tests
GitHub Check: Lint Packages
GitHub Check: Size
GitHub Check: Build Packages
GitHub Check: Analyze (javascript)

✨ Finishing Touches

📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

MananTank · 2025-07-01T18:04:03Z

Dashboard: Add missing asset creation successs tracking for nft #7494 👈 (View in Graphite)
main

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

merge-queue - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

codecov · 2025-07-01T18:06:12Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.92%. Comparing base (c356813) to head (030c522).
Report is 2 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #7494   +/-   ##
=======================================
  Coverage   51.92%   51.92%           
=======================================
  Files         949      949           
  Lines       64148    64148           
  Branches     4229     4229           
=======================================
  Hits        33311    33311           
  Misses      30731    30731           
  Partials      106      106

Flag	Coverage Δ
packages	`51.92% <ø> (ø)`

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

github-actions · 2025-07-01T18:08:44Z

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
thirdweb (esm)	63.11 KB (0%)	1.3 s (0%)	174 ms (+43.81% 🔺)	1.5 s
thirdweb (cjs)	352.76 KB (0%)	7.1 s (0%)	898 ms (-6.86% 🔽)	8 s
thirdweb (minimal + tree-shaking)	5.72 KB (0%)	115 ms (0%)	39 ms (+573.34% 🔺)	153 ms
thirdweb/chains (tree-shaking)	530 B (0%)	11 ms (0%)	31 ms (+1217.99% 🔺)	41 ms
thirdweb/react (minimal + tree-shaking)	19.59 KB (0%)	392 ms (0%)	145 ms (+763.02% 🔺)	536 ms

graphite-app · 2025-07-01T19:59:44Z

Merge activity

Jul 1, 7:59 PM UTC: MananTank added this pull request to the Graphite merge queue.
Jul 1, 8:09 PM UTC: Merged by the Graphite merge queue.

--- ## PR-Codex overview This PR focuses on enhancing the NFT launch functionality by adding a successful asset creation report feature. It imports a new reporting function and invokes it upon successful NFT launch, improving analytics tracking. ### Detailed summary - Added import for `reportAssetCreationSuccessful` from `@/analytics/report`. - Called `reportAssetCreationSuccessful` with parameters indicating asset type and contract type upon successful NFT launch. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`   ## Summary by CodeRabbit * **New Features** * Added a success reporting step after completing the NFT launch process, providing improved feedback for successful NFT creation.

vercel bot temporarily deployed to Preview – nebula July 1, 2025 18:03 Inactive

vercel bot temporarily deployed to Preview – docs-v2 July 1, 2025 18:03 Inactive

vercel bot temporarily deployed to Preview – thirdweb_playground July 1, 2025 18:03 Inactive

vercel bot temporarily deployed to Preview – wallet-ui July 1, 2025 18:03 Inactive

github-actions bot assigned MananTank Jul 1, 2025

github-actions bot added the Dashboard Involves changes to the Dashboard. label Jul 1, 2025

vercel bot deployed to Preview – thirdweb-www July 1, 2025 18:11 View deployment

MananTank marked this pull request as ready for review July 1, 2025 18:53

MananTank requested review from a team as code owners July 1, 2025 18:53

joaquim-verges approved these changes Jul 1, 2025

View reviewed changes

graphite-app bot force-pushed the 07-01-dashboard_add_missing_asset_creation_successs_tracking_for_nft branch from c07755c to 030c522 Compare July 1, 2025 20:00

vercel bot temporarily deployed to Preview – wallet-ui July 1, 2025 20:00 Inactive

vercel bot temporarily deployed to Preview – thirdweb_playground July 1, 2025 20:00 Inactive

vercel bot temporarily deployed to Preview – nebula July 1, 2025 20:00 Inactive

vercel bot temporarily deployed to Preview – docs-v2 July 1, 2025 20:00 Inactive

vercel bot deployed to Preview – thirdweb-www July 1, 2025 20:08 View deployment

graphite-app bot merged commit 030c522 into main Jul 1, 2025
24 checks passed

graphite-app bot deleted the 07-01-dashboard_add_missing_asset_creation_successs_tracking_for_nft branch July 1, 2025 20:09

vercel bot temporarily deployed to Production – thirdweb_playground July 1, 2025 20:09 Inactive

vercel bot temporarily deployed to Production – wallet-ui July 1, 2025 20:09 Inactive

vercel bot temporarily deployed to Production – nebula July 1, 2025 20:09 Inactive

vercel bot temporarily deployed to Production – docs-v2 July 1, 2025 20:09 Inactive

vercel bot deployed to Production – thirdweb-www July 1, 2025 20:18 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Dashboard: Add missing asset creation successs tracking for nft #7494

Dashboard: Add missing asset creation successs tracking for nft #7494

Uh oh!

MananTank commented Jul 1, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

vercel bot commented Jul 1, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Jul 1, 2025 •

edited

Loading

Review ran into problems

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

MananTank commented Jul 1, 2025

Uh oh!

codecov bot commented Jul 1, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jul 1, 2025 •

edited

Loading

Uh oh!

graphite-app bot commented Jul 1, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Dashboard: Add missing asset creation successs tracking for nft #7494

Dashboard: Add missing asset creation successs tracking for nft #7494

Uh oh!

Conversation

MananTank commented Jul 1, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR-Codex overview

Detailed summary

Summary by CodeRabbit

Uh oh!

vercel bot commented Jul 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Jul 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Possibly related PRs

Suggested reviewers

Review ran into problems

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

MananTank commented Jul 1, 2025

How to use the Graphite Merge Queue

Uh oh!

codecov bot commented Jul 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Jul 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

graphite-app bot commented Jul 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Uh oh!

MananTank commented Jul 1, 2025 •

edited by coderabbitai bot

Loading

vercel bot commented Jul 1, 2025 •

edited

Loading

coderabbitai bot commented Jul 1, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

codecov bot commented Jul 1, 2025 •

edited

Loading

github-actions bot commented Jul 1, 2025 •

edited

Loading

graphite-app bot commented Jul 1, 2025 •

edited

Loading