Skip to content

[Dashboard] Move RPC Edge to scale category and remove redirect #7495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jnsdls
Copy link
Member

@jnsdls jnsdls commented Jul 1, 2025

TL;DR

Reorganized navigation structure by adding a "scale category" and removing the RPC Edge redirect.

What changed?

  • Created a new "scale category" in the framer-rewrites.js file that includes:
    • /rpc-edge
    • /insight
    • /storage
  • Moved /storage from its own category into the new "scale category"
  • Moved /insight from its own category into the new "scale category"
  • Removed the redirect from /rpc-edge to the portal URL in redirects.js

How to test?

  1. Verify that the /rpc-edge, /insight, and /storage routes are properly grouped under the "scale category"
  2. Confirm that navigating to /rpc-edge no longer redirects to the portal URL
  3. Check that the other redirects still function as expected

Why make this change?

This change improves the organization of related services under a logical "scale category" grouping, making the navigation structure more intuitive. It also enables direct access to the RPC Edge page rather than redirecting users to the portal, providing a more seamless user experience.

Summary by CodeRabbit

  • Refactor

    • Reorganized and regrouped certain dashboard paths under a new "scale category" for improved clarity.
  • Chores

    • Removed a redirect rule for the /rpc-edge path.

PR-Codex overview

This PR focuses on updating the framer-rewrites.js and redirects.js files in the dashboard application. It modifies comments and adjusts the routing structure related to the handling of certain paths.

Detailed summary

  • In framer-rewrites.js:

    • Changed comment from // -- storage to // -- scale category.
    • Added // -- end scale category.
    • Removed // --insight and the corresponding "/insight" line.
  • In redirects.js:

    • Removed the redirect configuration for "/rpc-edge" to the portal.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Jul 1, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 1, 2025 8:46pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Jul 1, 2025 8:46pm
nebula ⬜️ Skipped (Inspect) Jul 1, 2025 8:46pm
thirdweb_playground ⬜️ Skipped (Inspect) Jul 1, 2025 8:46pm
wallet-ui ⬜️ Skipped (Inspect) Jul 1, 2025 8:46pm

@vercel vercel bot temporarily deployed to Preview – wallet-ui July 1, 2025 20:06 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 July 1, 2025 20:06 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground July 1, 2025 20:06 Inactive
@vercel vercel bot temporarily deployed to Preview – nebula July 1, 2025 20:06 Inactive
Copy link
Contributor

coderabbitai bot commented Jul 1, 2025

Walkthrough

The changes reorganize and annotate the export list in framer-rewrites.js, introducing a new "scale category" section and relocating certain paths within it. Additionally, a redirect rule for /rpc-edge is removed from redirects.js. No new features or exported entities are introduced or removed.

Changes

File(s) Change Summary
apps/dashboard/framer-rewrites.js Reorganized exported paths by adding a "scale category" section and moving /insight and /rpc-edge into it.
apps/dashboard/redirects.js Removed the redirect rule for /rpc-edge.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8fc1548 and 02f6f87.

📒 Files selected for processing (2)
  • apps/dashboard/framer-rewrites.js (1 hunks)
  • apps/dashboard/redirects.js (0 hunks)
💤 Files with no reviewable changes (1)
  • apps/dashboard/redirects.js
🚧 Files skipped from review as they are similar to previous changes (1)
  • apps/dashboard/framer-rewrites.js
⏰ Context from checks skipped due to timeout of 90000ms (8)
  • GitHub Check: E2E Tests (pnpm, esbuild)
  • GitHub Check: E2E Tests (pnpm, vite)
  • GitHub Check: E2E Tests (pnpm, webpack)
  • GitHub Check: Size
  • GitHub Check: Unit Tests
  • GitHub Check: Build Packages
  • GitHub Check: Lint Packages
  • GitHub Check: Analyze (javascript)
✨ Finishing Touches
  • 📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Jul 1, 2025
@jnsdls jnsdls marked this pull request as ready for review July 1, 2025 20:07
@jnsdls jnsdls requested review from a team as code owners July 1, 2025 20:07
Copy link
Member Author

jnsdls commented Jul 1, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codecov bot commented Jul 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.92%. Comparing base (1305527) to head (02f6f87).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7495   +/-   ##
=======================================
  Coverage   51.92%   51.92%           
=======================================
  Files         949      949           
  Lines       64148    64148           
  Branches     4229     4229           
=======================================
  Hits        33311    33311           
  Misses      30731    30731           
  Partials      106      106           
Flag Coverage Δ
packages 51.92% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

github-actions bot commented Jul 1, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 63.11 KB (0%) 1.3 s (0%) 510 ms (+109.17% 🔺) 1.8 s
thirdweb (cjs) 352.76 KB (0%) 7.1 s (0%) 1.9 s (+0.57% 🔺) 8.9 s
thirdweb (minimal + tree-shaking) 5.72 KB (0%) 115 ms (0%) 181 ms (+924.66% 🔺) 295 ms
thirdweb/chains (tree-shaking) 530 B (0%) 11 ms (0%) 33 ms (+497.43% 🔺) 43 ms
thirdweb/react (minimal + tree-shaking) 19.59 KB (0%) 392 ms (0%) 183 ms (+393.61% 🔺) 574 ms

Copy link
Contributor

graphite-app bot commented Jul 1, 2025

Merge activity

### TL;DR

Reorganized navigation structure by adding a "scale category" and removing the RPC Edge redirect.

### What changed?

- Created a new "scale category" in the framer-rewrites.js file that includes:
  - `/rpc-edge`
  - `/insight`
  - `/storage`
- Moved `/storage` from its own category into the new "scale category"
- Moved `/insight` from its own category into the new "scale category"
- Removed the redirect from `/rpc-edge` to the portal URL in redirects.js

### How to test?

1. Verify that the `/rpc-edge`, `/insight`, and `/storage` routes are properly grouped under the "scale category"
2. Confirm that navigating to `/rpc-edge` no longer redirects to the portal URL
3. Check that the other redirects still function as expected

### Why make this change?

This change improves the organization of related services under a logical "scale category" grouping, making the navigation structure more intuitive. It also enables direct access to the RPC Edge page rather than redirecting users to the portal, providing a more seamless user experience.

<!-- This is an auto-generated comment: release notes by coderabbit.ai -->

## Summary by CodeRabbit

* **Refactor**
  * Reorganized and regrouped certain dashboard paths under a new "scale category" for improved clarity.

* **Chores**
  * Removed a redirect rule for the /rpc-edge path.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
@graphite-app graphite-app bot force-pushed the _Dashboard_Move_RPC_Edge_to_scale_category_and_remove_redirect branch from 8fc1548 to 02f6f87 Compare July 1, 2025 20:38
Copy link

changeset-bot bot commented Jul 1, 2025

⚠️ No Changeset found

Latest commit: 02f6f87

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – wallet-ui July 1, 2025 20:38 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 July 1, 2025 20:38 Inactive
@vercel vercel bot temporarily deployed to Preview – nebula July 1, 2025 20:38 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground July 1, 2025 20:38 Inactive
@graphite-app graphite-app bot merged commit 02f6f87 into main Jul 1, 2025
24 checks passed
@graphite-app graphite-app bot deleted the _Dashboard_Move_RPC_Edge_to_scale_category_and_remove_redirect branch July 1, 2025 20:47
@vercel vercel bot temporarily deployed to Production – wallet-ui July 1, 2025 20:47 Inactive
@vercel vercel bot temporarily deployed to Production – nebula July 1, 2025 20:47 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground July 1, 2025 20:47 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants