-
Notifications
You must be signed in to change notification settings - Fork 559
Version Packages #7501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version Packages #7501
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WalkthroughThis update removes two changeset markdown files, adds new changelog entries for three packages, and increments the version numbers in their respective Changes
Possibly related PRs
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (8)
💤 Files with no reviewable changes (2)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (5)
⏰ Context from checks skipped due to timeout of 90000ms (8)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
cedb12e
to
31c2b9d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (6)
packages/wagmi-adapter/CHANGELOG.md (1)
3-4
: Add meaningful release notes for 0.2.102
The new version header is empty. Even for dependency-only bumps, a brief note (e.g. “No functional changes – version bump only to align withthirdweb
5.105.5”) helps consumers and future maintainers understand why the publish happened.packages/wagmi-adapter/package.json (1)
58-58
: Missingsize-limit
budget required by repo guidelines
Per the workspace guidelinepackages/*/package.json#size-limit
, every package should declare a bundle budget. Consider adding one to prevent accidental bloat.Diff sketch (insert anywhere in the root object, usually after
scripts
):"typings": "./dist/types/exports/thirdweb.d.ts", "version": "0.2.102", + "size-limit": [ + { + "path": "./dist/esm/exports/thirdweb.js", + "limit": "30 KB" + } + ] }packages/thirdweb/package.json (1)
407-407
: Consider defining asize-limit
budgetThe script section already wires up
size-limit
, but the manifest is missing the actual budget block. Adding it now will guard against accidental bundle bloat.+ "size-limit": [ + { + "path": "./dist/esm/exports/thirdweb.js", + "limit": "200 kB" + } + ],Let me know if you’d like an automated follow-up PR that locks the limit to the current artefact size.
packages/nebula/package.json (1)
3-3
: Add a bundle budget to keep Nebula slimThe
size
script is present but no"size-limit"
block exists. A small explicit budget (e.g. 50 kB) will flag regressions early.+ "size-limit": [ + { + "path": "./dist/esm/exports/thirdweb.js", + "limit": "50 kB" + } + ],packages/nebula/CHANGELOG.md (1)
3-9
: Changelog clarityConsider adding a short note explaining that this patch indirectly restores borders on embed widgets via the
thirdweb
upgrade. Keeps the changelog self-contained for Nebula users.packages/thirdweb/CHANGELOG.md (1)
3-10
: Add release date to follow common changelog conventionsIncluding the release date (e.g., “2025-07-01”) immediately after the
## 5.105.5
heading improves traceability and aligns with the Keep a Changelog pattern used by many consumers and tooling.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (8)
.changeset/crazy-regions-send.md
(0 hunks).changeset/fresh-words-learn.md
(0 hunks)packages/nebula/CHANGELOG.md
(1 hunks)packages/nebula/package.json
(1 hunks)packages/thirdweb/CHANGELOG.md
(1 hunks)packages/thirdweb/package.json
(1 hunks)packages/wagmi-adapter/CHANGELOG.md
(1 hunks)packages/wagmi-adapter/package.json
(1 hunks)
💤 Files with no reviewable changes (2)
- .changeset/crazy-regions-send.md
- .changeset/fresh-words-learn.md
🧰 Additional context used
📓 Path-based instructions (1)
`packages/*/package.json`: Track bundle budgets via `package.json#size-limit` De-duplicate dependencies across packages through pnpm workspace hoisting
packages/*/package.json
: Track bundle budgets viapackage.json#size-limit
De-duplicate dependencies across packages through pnpm workspace hoisting
📄 Source: CodeRabbit Inference Engine (CLAUDE.md)
List of files the instruction was applied to:
packages/thirdweb/package.json
packages/wagmi-adapter/package.json
packages/nebula/package.json
🧠 Learnings (6)
📓 Common learnings
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T10:25:29.488Z
Learning: Surface breaking changes prominently in PR descriptions
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T10:25:29.489Z
Learning: Applies to packages/wagmi-adapter/**/*.{ts,tsx} : Wagmi ecosystem integration is in `packages/wagmi-adapter/`
packages/wagmi-adapter/CHANGELOG.md (1)
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T10:25:29.489Z
Learning: Applies to packages/wagmi-adapter/**/*.{ts,tsx} : Wagmi ecosystem integration is in `packages/wagmi-adapter/`
packages/thirdweb/package.json (4)
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T10:25:29.488Z
Learning: Applies to packages/thirdweb/src/exports/**/*.{ts,tsx} : Export everything via `exports/` directory, grouped by feature in the public API of the SDK
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T10:25:29.488Z
Learning: Surface breaking changes prominently in PR descriptions
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T10:25:29.488Z
Learning: Applies to packages/thirdweb/src/exports/**/*.{ts,tsx} : Every public symbol must have comprehensive TSDoc with at least one `@example` block that compiles and custom annotation tags (`@beta`, `@internal`, `@experimental`)
Learnt from: MananTank
PR: thirdweb-dev/js#7356
File: apps/nebula/src/app/not-found.tsx:1-1
Timestamp: 2025-06-17T18:30:52.976Z
Learning: In the thirdweb/js project, the React namespace is available for type annotations (like React.FC) without needing to explicitly import React. This is project-specific configuration that differs from typical TypeScript/React setups.
packages/wagmi-adapter/package.json (4)
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T10:25:29.489Z
Learning: Applies to packages/wagmi-adapter/**/*.{ts,tsx} : Wagmi ecosystem integration is in `packages/wagmi-adapter/`
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T10:25:29.488Z
Learning: Applies to packages/thirdweb/src/exports/**/*.{ts,tsx} : Export everything via `exports/` directory, grouped by feature in the public API of the SDK
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T10:25:29.488Z
Learning: Applies to packages/thirdweb/src/exports/**/*.{ts,tsx} : Every public symbol must have comprehensive TSDoc with at least one `@example` block that compiles and custom annotation tags (`@beta`, `@internal`, `@experimental`)
Learnt from: MananTank
PR: thirdweb-dev/js#7356
File: apps/nebula/src/app/not-found.tsx:1-1
Timestamp: 2025-06-17T18:30:52.976Z
Learning: In the thirdweb/js project, the React namespace is available for type annotations (like React.FC) without needing to explicitly import React. This is project-specific configuration that differs from typical TypeScript/React setups.
packages/nebula/CHANGELOG.md (1)
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T10:25:29.488Z
Learning: Surface breaking changes prominently in PR descriptions
packages/thirdweb/CHANGELOG.md (1)
undefined
<retrieved_learning>
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T10:25:29.488Z
Learning: Surface breaking changes prominently in PR descriptions
</retrieved_learning>
⏰ Context from checks skipped due to timeout of 90000ms (8)
- GitHub Check: Size
- GitHub Check: Unit Tests
- GitHub Check: E2E Tests (pnpm, esbuild)
- GitHub Check: E2E Tests (pnpm, vite)
- GitHub Check: E2E Tests (pnpm, webpack)
- GitHub Check: Lint Packages
- GitHub Check: Build Packages
- GitHub Check: Analyze (javascript)
🔇 Additional comments (2)
packages/thirdweb/package.json (1)
407-407
: Patch version bump LGTM5.105.4 → 5.105.5 matches the CHANGELOG entry and the workspace dependency updates. No issues spotted.
packages/nebula/package.json (1)
3-3
: Patch version bump looks correct0.2.4 → 0.2.5 correctly tracks the upgraded
thirdweb
peer. ✅
size-limit report 📦
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7501 +/- ##
=======================================
Coverage 51.96% 51.96%
=======================================
Files 952 952
Lines 64227 64227
Branches 4238 4238
=======================================
Hits 33377 33377
Misses 30743 30743
Partials 107 107
🚀 New features to boost your workflow:
|
31c2b9d
to
5863db1
Compare
5863db1
to
cd99ef7
Compare
cd99ef7
to
8231186
Compare
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@thirdweb-dev/[email protected]
Patch Changes
ec75d95
,50e01ce
,85c4ef1
,7ab8808
,fd967ce
]:[email protected]
Patch Changes
#7486
ec75d95
Thanks @Yash094! - add core chains#7487
50e01ce
Thanks @MananTank! - Restore border on embed components:ConnectEmbed
,BuyWidget
,CheckoutWidget
,TransactionWidget
#7474
85c4ef1
Thanks @emmaodia! - Add Somnia Testnet#7503
7ab8808
Thanks @joaquim-verges! - Handle very large numbers in BuyWidget#7507
fd967ce
Thanks @0xFirekeeper! - Fix purchaseData propagation in PayEmbed component to new widget implementations@thirdweb-dev/[email protected]
PR-Codex overview
This PR focuses on updating version numbers in several
package.json
files and adding new entries to theCHANGELOG.md
files for various packages, reflecting recent changes and dependency updates.Detailed summary
version
inpackages/thirdweb/package.json
from5.105.4
to5.105.5
version
inpackages/wagmi-adapter/package.json
from0.2.101
to0.2.102
version
inpackages/nebula/package.json
from0.2.4
to0.2.5
nebula
version0.2.5
with dependency updatesthirdweb
version5.105.5
detailing multiple feature enhancements and fixesSummary by CodeRabbit
Documentation
Chores