Add featured and single wallet options to Reown integration #244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces support for 'featuredWalletIds' and 'singleWalletId' in ReownOptions, allowing more granular control over wallet selection in the Reown wallet integration. Updates the PlaygroundManager example to showcase these new options and adds an OAuthProvider enum for improved social login handling. Also updates Reown package dependencies to version 1.5.1.
WalkthroughThis PR adds OAuth provider selection and social wallet support, extends Reown configuration with FeaturedWalletIds and SingleWalletId (including validation), updates Reown connection flow to support direct single-wallet connections, and bumps multiple Reown package versions from 1.5.0 to 1.5.1. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Playground as PlaygroundManager
participant ReownWallet
participant AppKit
rect rgb(245,245,245)
Note over User,AppKit: Single-wallet flow (SingleWalletId present)
User->>Playground: Select Reown wallet
Playground->>ReownWallet: Create(..., singleWalletId="id")
ReownWallet->>ReownWallet: Clear AppKit included/excluded/featured
ReownWallet->>AppKit: ConnectAsync(singleWalletId)
AppKit->>User: Direct connect (no modal)
end
rect rgb(240,250,240)
Note over User,AppKit: Featured-wallets flow (FeaturedWalletIds present)
User->>Playground: Select Reown wallet
Playground->>ReownWallet: Create(..., featuredWalletIds=[...])
ReownWallet->>ReownWallet: Populate AppKit featured list
ReownWallet->>AppKit: OpenModal()
AppKit->>User: Show modal with featured wallets
end
rect rgb(250,240,245)
Note over User,Playground: OAuth social flow
User->>Playground: Choose Social provider
Playground->>Playground: Map OAuthProvider -> AuthProvider
Playground->>InAppWallet: Create/InAppWalletOptions(authProvider)
InAppWallet->>User: OAuth authentication flow
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro Disabled knowledge base sources:
📒 Files selected for processing (1)
🧰 Additional context used🧬 Code graph analysis (1)Assets/Thirdweb/Examples/Scripts/PlaygroundManager.cs (2)
🔇 Additional comments (1)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
Assets/Thirdweb/Examples/Scripts/PlaygroundManager.cs (1)
149-151: Guard against enum drift at runtime.
Enum.Parsewill throw ifOAuthProviderever gains a value thatAuthProviderdoesn’t recognize. UsingEnum.TryParsewith a safe fallback (e.g.,AuthProvider.Default) would keep the playground from hard-crashing during demos while still supporting future additions.- var parsedOAuthProvider = (AuthProvider)System.Enum.Parse(typeof(AuthProvider), this.Social.ToString()); + if (!System.Enum.TryParse<AuthProvider>(this.Social.ToString(), out var parsedOAuthProvider)) + { + parsedOAuthProvider = AuthProvider.Default; + }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (5)
Assets/Thirdweb/Examples/Scripts/PlaygroundManager.cs(4 hunks)Assets/Thirdweb/Runtime/Unity/ThirdwebManagerBase.cs(2 hunks)Assets/Thirdweb/Runtime/Unity/Wallets/Reown/ReownWallet.cs(5 hunks)Packages/manifest.json(1 hunks)Packages/packages-lock.json(2 hunks)
🧰 Additional context used
🧬 Code graph analysis (1)
Assets/Thirdweb/Examples/Scripts/PlaygroundManager.cs (2)
Assets/Thirdweb/Runtime/Unity/ThirdwebManagerBase.cs (4)
WalletOptions(233-248)InAppWalletOptions(22-43)ReownOptions(184-209)SmartWalletOptions(134-151)Assets/Thirdweb/Runtime/Unity/Wallets/Reown/ReownWallet.cs (2)
ReownWallet(14-355)ReownWallet(24-24)
🔇 Additional comments (1)
Assets/Thirdweb/Runtime/Unity/Wallets/Reown/ReownWallet.cs (1)
301-308: Graceful direct-connect fallback looks solid.Nice touch using
singleWalletIdto try a directConnectAsyncbefore falling back to the modal—captures the single-wallet UX without breaking existing multi-wallet behavior.
Replaces Enum.Parse with Enum.TryParse for social auth provider selection. Defaults to Google provider if parsing fails, preventing potential runtime errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces support for 'featuredWalletIds' and 'singleWalletId' in ReownOptions, allowing more granular control over wallet selection in the Reown wallet integration. Updates the PlaygroundManager example to showcase these new options and adds an OAuthProvider enum for improved social login handling. Also updates Reown package dependencies to version 1.5.1.
PR-Codex overview
This PR focuses on updating the version of several
com.reownpackages inmanifest.jsonand adding new properties to theReownOptionsclass inThirdwebManagerBase.csto enhance wallet connection functionality, including support for featured wallets and single wallet IDs.Detailed summary
com.reownpackages from version1.5.0to1.5.1inPackages/manifest.json.FeaturedWalletIdsandSingleWalletIdproperties toReownOptionsinThirdwebManagerBase.cs.SingleWalletIdwith other wallet ID options.ConnectWalletmethod.ReownWalletclass to handle new wallet options.OAuthProviderenum inPlaygroundManager.csfor social login options.Wallet_Socialmethod to parse the newSocialproperty and use it for wallet options.Wallet_External_Directmethod for direct wallet connection usingSingleWalletId.Summary by CodeRabbit
New Features
Chores