-
Notifications
You must be signed in to change notification settings - Fork 14
Support v7 Account Abstraction #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Introduces an EntryPoint parameter to the smart wallet creation flow across C++, Blueprint, and K2Node interfaces. Updates the Thirdweb native bindings, async task, handle, and node logic to support specifying an entry point contract when creating a smart wallet. Closes BLD-12
WalkthroughThis change adds support for an "EntryPoint" parameter in the creation of smart wallets across the Unreal Engine integration, affecting C++, Blueprint node, and FFI boundaries. It updates function signatures, class members, and binary artifacts for all supported platforms to include and handle the new EntryPoint parameter. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant BlueprintNode
participant AsyncTask
participant SmartWalletHandle
participant FFI (Thirdweb)
User->>BlueprintNode: Initiate smart wallet creation (with EntryPoint)
BlueprintNode->>AsyncTask: CreateSmartWallet(EntryPoint)
AsyncTask->>SmartWalletHandle: Create(..., EntryPoint, ...)
SmartWalletHandle->>FFI (Thirdweb): create_smart_wallet(..., entry_point)
FFI (Thirdweb)-->>SmartWalletHandle: Result
SmartWalletHandle-->>AsyncTask: Success/Failure callback
AsyncTask-->>BlueprintNode: Notify result
BlueprintNode-->>User: Return result
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Assessment against linked issues
Assessment against linked issues: Out-of-scope changesNo out-of-scope changes found. Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (14)
🧰 Additional context used🧬 Code Graph Analysis (2)Source/Thirdweb/Public/Wallets/ThirdwebSmartWalletHandle.h (1)
Source/ThirdwebUncookedOnly/Public/K2Node/K2Node_ThirdwebCreateWallet.h (1)
🔇 Additional comments (22)
✨ Finishing Touches
🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Introduces an EntryPoint parameter to the smart wallet creation flow across C++, Blueprint, and K2Node interfaces. Updates the Thirdweb native bindings, async task, handle, and node logic to support specifying an entry point contract when creating a smart wallet.
Closes BLD-12
Summary by CodeRabbit
New Features
Bug Fixes
Other Updates