Skip to content

Commit

Permalink
Dropped support for IE8 in CSS. (django#718)
Browse files Browse the repository at this point in the history
  • Loading branch information
timgraham authored and jezdez committed Nov 8, 2016
1 parent f407ea7 commit d34868f
Show file tree
Hide file tree
Showing 6 changed files with 7 additions and 64 deletions.
2 changes: 0 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,9 @@ collectstatics: compile-scss

compile-scss:
sassc $(SCSS)/output.scss $(STATIC)/css/output.css -s compressed
sassc $(SCSS)/output-ie.scss $(STATIC)/css/output-ie.css -s compressed

compile-scss-debug:
sassc $(SCSS)/output.scss $(STATIC)/css/output.css --sourcemap
sassc $(SCSS)/output-ie.scss $(STATIC)/css/output-ie.css --sourcemap

watch-scss:
watchmedo shell-command --patterns=*.scss --recursive --command="make compile-scss-debug" $(SCSS)
Expand Down
9 changes: 3 additions & 6 deletions README.rst
Original file line number Diff line number Diff line change
Expand Up @@ -179,13 +179,10 @@ SVG, webfonts.
We're following `Mozilla's example <https://wiki.mozilla.org/Support/Browser_Support>`_
when it comes to categorize browser support.

- Any browser other than IE8 and lower as **A grade**. Which means everything
needs to work on those.
- Desktop browsers, except as noted below, are **A grade**, meaning that
everything needs to work.

- IE8 is **B grade**, meaning that some functionality may be disabled, visual
variations are acceptable but the content must work nevertheless.

- IE below 8 is **not supported**.
- IE < 11 is **not supported** (based on Microsoft's support).

- Mobile browsers should be considered **B grade** as well.
Mobile Safari, Firefox on Android and the Android Browser should support
Expand Down
18 changes: 0 additions & 18 deletions djangoproject/scss/_style.scss
Original file line number Diff line number Diff line change
Expand Up @@ -402,9 +402,6 @@ blockquote {
max-width: 1400px;
padding: 0 (32/768) * 100%;
}
@include old-ie {
min-width: 768px;
}

&.sidebar-right {
.mdzr-boxshadow & {
Expand Down Expand Up @@ -1190,10 +1187,6 @@ blockquote {
font-size: 1.2em;
}
}
@include old-ie {
display: inline;
zoom: 1;
}
font-weight: 700;
text-transform: uppercase;

Expand Down Expand Up @@ -1378,19 +1371,12 @@ blockquote {

li {
margin-top: 10px;
@include old-ie {
display: block;
line-height: 28px;
}
}

a {
background: $green-light;
color: $white;
display: inline-block;
@include old-ie {
display: block;
}
line-height: 1.2;
margin: 0;
padding: 8px 10px 5px;
Expand Down Expand Up @@ -2801,10 +2787,6 @@ div[role=main] {

li{
display: inline-block;
@include old-ie {
display: inline;
zoom: 1;
}
}
a {
border: none;
Expand Down
32 changes: 3 additions & 29 deletions djangoproject/scss/_utils.scss
Original file line number Diff line number Diff line change
Expand Up @@ -42,37 +42,14 @@ $font-path: "../fonts/fira-mono";
}

// Media Queries Mixin (http://jakearchibald.github.com/sass-ie/)
$fix-mqs: false !default;
@mixin respond-min($width) {
@if $fix-mqs {
@if $fix-mqs >= $width {
@content;
}
}
@else {
@media screen and (min-width: $width) {
@content;
}
@media screen and (min-width: $width) {
@content;
}
}

@mixin device-min($width) {
@if $fix-mqs {
@if $fix-mqs >= $width {
@content;
}
}
@else {
@media screen and (min-device-width: $width) {
@content;
}
}
}

// OLD IE Mixin (http://jakearchibald.github.com/sass-ie/)
$old-ie: false !default;
@mixin old-ie {
@if $old-ie {
@media screen and (min-device-width: $width) {
@content;
}
}
Expand Down Expand Up @@ -128,9 +105,6 @@ html {
&:after {
clear: both;
}
@include old-ie {
zoom: 1;
}
}

@mixin svg-image ( $name ) {
Expand Down
3 changes: 0 additions & 3 deletions djangoproject/scss/output-ie.scss

This file was deleted.

7 changes: 1 addition & 6 deletions djangoproject/templates/base.html
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,7 @@

<title>{% block title %}The Web framework for perfectionists with deadlines{% endblock %} | Django</title>

<!--[if lte IE 8]>
<link rel="stylesheet" href="{% static "css/output-ie.css" %}" >
<![endif]-->
<!--[if gt IE 8]><!-->
<link rel="stylesheet" href="{% static "css/output.css" %}" >
<!--<![endif]-->
<link rel="stylesheet" href="{% static "css/output.css" %}" >
<script src="{% static "js/lib/webfontloader/webfontloader.js" %}"></script>
<script>
WebFont.load({
Expand Down

0 comments on commit d34868f

Please sign in to comment.