Skip to content

Conversation

bfanger
Copy link

@bfanger bfanger commented Feb 18, 2025

  • Remove docker container after "composer install" was completed
  • Removed incorrect indent_size (2 spaces was used) setting
  • Fixed warning: "the attribute version is obsolete, it will be ignored, please remove it to avoid potential confusion"
  • Use "docker compose" instead of the deprecated "docker-compose" command

@ederuiter
Copy link
Contributor

All files in this repo are generated from https://github.com/thisisdevelopment/laravel-base-builder; can you make the PR there instead? This allows us to keep in sync with upstream laravel

Also removing the version string from the docker-compose file is not backwards compatible with older versions of docker (unfortunately)

@bfanger bfanger closed this Feb 18, 2025
@bfanger
Copy link
Author

bfanger commented Feb 18, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants