-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pushing working parser #1
base: master
Are you sure you want to change the base?
Conversation
@diyorzakirov07 please use doxygen-style python comments and include at least a |
parseShort.py
Outdated
#The regex creates a pattern to find matches in the file | ||
#Checks for USE and possible & on the same or next line, until module name is found signified by the '?' | ||
#Ignores cases and tries to match on all lines |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use doxygen comments, preferably the ## style suggested here
parse.py
Outdated
if md == mods[0]: | ||
alreadyExists = True | ||
if vv: | ||
print(fname,": the module ",md," is listd more than once. only keeping one") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a typo in "listed"
parse.py
Outdated
if md == mods[0]: | ||
alreadyExists = True | ||
if vv: | ||
print(fname,": the module ",md," is listd more than once. only keeping one") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@diyorzakirov07 another "listed" typo
@diyorzakirov07 how should I run this? Can you updated the README for running instructions? |
@thomas-robinson only parseShort.py actually runs, you should be able to just call for the main method and it would print the array with module dependencies |
@diyorzakirov07 i tried |
Diyorzakirov07/mkmf license
@diyorzakirov07 When I run mkmf, I get this printed out:
This seems like some debugging prints that should be taken out. When I run outside of the mkmf directory:
When I run for FMS xanadu with a bunch of extra junk:
When I run with a clean FMS (xanadu), is runs to completion. Your -v and -vv options list "Files to parse:", but the list is actually the directories. The -vv option should list each individual file, and maybe even the dependencies. The -v option could just list the file being worked on. They should both list any CPPDEFS or other options. |
No description provided.