build: Remove LevelDB support

Whereas new LevelDB packages are build with -fno-rtti and break our attempts to compile against them, and whereas LevelDB has been deprecated for some time, with the Ceph team expending great effort to migrating OSDs off of it, let it be therefore removed. Signed-off-by: Adam C. Emerson <[email protected]>
thomasgoirand · Nov 1, 2021 · 447564e · 447564e
1 parent 352399d
commit 447564e
Show file tree

Hide file tree

Showing 12 changed files with 4 additions and 925 deletions.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -297,16 +297,6 @@ if(LINUX)
   endif()
 endif()
 
-option(WITH_LEVELDB "LevelDB is here" ON)
-if(WITH_LEVELDB)
-  if(LEVELDB_PREFIX)
-    include_directories(SYSTEM ${LEVELDB_PREFIX}/include)
-    link_directories(${LEVELDB_PREFIX}/lib)
-  endif()
-  find_package(leveldb REQUIRED)
-  find_file(HAVE_LEVELDB_FILTER_POLICY leveldb/filter_policy.h PATHS ${LEVELDB_INCLUDE_DIR})
-endif(WITH_LEVELDB)
-
 find_package(snappy REQUIRED)
 
 option(WITH_BROTLI "Brotli compression support" OFF)

diff --git a/ceph.spec.in b/ceph.spec.in
@@ -200,7 +200,6 @@ BuildRequires:	gperftools-devel >= 2.6.1
 BuildRequires:	gperftools-devel >= 2.4
 %endif
 %endif
-BuildRequires:	leveldb-devel > 1.2
 BuildRequires:	libaio-devel
 BuildRequires:	libblkid-devel >= 2.17
 BuildRequires:	cryptsetup-devel

diff --git a/cmake/modules/Findleveldb.cmake b/cmake/modules/Findleveldb.cmake
diff --git a/debian/control b/debian/control
@@ -48,7 +48,6 @@ Build-Depends: automake,
                librdmacm-dev,
                libkeyutils-dev,
                libldap2-dev,
-               libleveldb-dev,
                liblttng-ust-dev,
                liblua5.3-dev,
                liblz4-dev (>= 0.0~r131),

diff --git a/src/include/config-h.in.cmake b/src/include/config-h.in.cmake
@@ -117,9 +117,6 @@
 /* PMEM_DEVICE (OSD) conditional compilation */
 #cmakedefine HAVE_BLUESTORE_PMEM
 
-/* Defined if LevelDB supports bloom filters */
-#cmakedefine HAVE_LEVELDB_FILTER_POLICY
-
 /* Define if you have tcmalloc */
 #cmakedefine HAVE_LIBTCMALLOC
 #cmakedefine LIBTCMALLOC_MISSING_ALIGNED_ALLOC
@@ -157,9 +154,6 @@
 /* define if radosgw enabled */
 #cmakedefine WITH_RADOSGW
 
-/* define if leveldb is enabled */
-#cmakedefine WITH_LEVELDB
-
 /* define if radosgw has openssl support */
 #cmakedefine WITH_CURL_OPENSSL
 

diff --git a/src/kv/CMakeLists.txt b/src/kv/CMakeLists.txt
@@ -6,13 +6,9 @@ set(kv_srcs
   rocksdb_cache/ShardedCache.cc
   rocksdb_cache/BinnedLRUCache.cc)
 
-if (WITH_LEVELDB)
-  list(APPEND kv_srcs LevelDBStore.cc)
-endif (WITH_LEVELDB)
-
 add_library(kv STATIC ${kv_srcs}
   $<TARGET_OBJECTS:common_prioritycache_obj>)
 
-target_link_libraries(kv ${LEVELDB_LIBRARIES}
+target_link_libraries(kv
   RocksDB::RocksDB
   heap_profiler)
diff --git a/src/kv/KeyValueDB.cc b/src/kv/KeyValueDB.cc
@@ -2,9 +2,6 @@
 // vim: ts=8 sw=2 smarttab
 
 #include "KeyValueDB.h"
-#ifdef WITH_LEVELDB
-#include "LevelDBStore.h"
-#endif
 #include "MemDB.h"
 #include "RocksDBStore.h"
 
@@ -16,11 +13,6 @@ KeyValueDB *KeyValueDB::create(CephContext *cct, const string& type,
 			       map<string,string> options,
 			       void *p)
 {
-#ifdef WITH_LEVELDB
-  if (type == "leveldb") {
-    return new LevelDBStore(cct, dir);
-  }
-#endif
   if (type == "rocksdb") {
     return new RocksDBStore(cct, dir, options, p);
   }
@@ -33,11 +25,6 @@ KeyValueDB *KeyValueDB::create(CephContext *cct, const string& type,
 
 int KeyValueDB::test_init(const string& type, const string& dir)
 {
-#ifdef WITH_LEVELDB
-  if (type == "leveldb") {
-    return LevelDBStore::_test_init(dir);
-  }
-#endif
   if (type == "rocksdb") {
     return RocksDBStore::_test_init(dir);
   }

diff --git a/src/kv/KeyValueDB.h b/src/kv/KeyValueDB.h
@@ -17,7 +17,7 @@
 /**
  * Defines virtual interface to be implemented by key value store
  *
- * Kyoto Cabinet or LevelDB should implement this
+ * Kyoto Cabinet should implement this
  */
 class KeyValueDB {
 public:
@@ -153,7 +153,7 @@ class KeyValueDB {
 
   virtual void close() { }
 
-  /// Try to repair K/V database. leveldb and rocksdb require that database must be not opened.
+  /// Try to repair K/V database. rocksdb requires that database must be not opened.
   virtual int repair(std::ostream &out) { return 0; }
 
   virtual Transaction get_transaction() = 0;