Cleanup in stat_sina() code, and remove limitation on maxwidth
#76
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request does two things:
It cleans up some code in
stat_sina
that makes no sense. In two cases,if
/else
codepaths execute the exact same code, so there's no need for theif
/else
construct.It removes the artificial limit on the
maxwidth
parameter. I provide an example below for a situation wheremaxwidth > 1
is appropriate.