Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TRdailyforecast view swift refactor #227

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

TRdailyforecast view swift refactor #227

wants to merge 5 commits into from

Conversation

katsuroo
Copy link
Contributor

@katsuroo katsuroo commented Jan 7, 2019

No description provided.

@katsuroo katsuroo requested a review from sharplet January 7, 2019 15:24
sharplet
sharplet reviewed Jan 7, 2019
View reviewed changes
Copy link
Contributor

@sharplet sharplet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

Sources/Tropos/Views/DailyForecastView.swift Outdated Show resolved Hide resolved
Sources/Tropos/Views/DailyForecastView.swift Outdated Show resolved Hide resolved
Sources/Tropos/Views/DailyForecastView.swift Outdated Show resolved Hide resolved
Sources/Tropos/Views/DailyForecastView.swift Outdated Show resolved Hide resolved
Sources/Tropos/Views/DailyForecastView.swift Outdated Show resolved Hide resolved
@sharplet
Copy link
Contributor

sharplet commented Jan 7, 2019

Looks like there’s some compile errors on CI:

[07:39:26]: ▸ ❌  /Users/distiller/project/Sources/Tropos/ViewControllers/TRWeatherViewController.m:22:38: unknown type name 'TRDailyForecastView'
[07:39:26]: ▸ @property (weak, nonatomic) IBOutlet TRDailyForecastView *oneDayForecastView;
[07:39:26]: ▸                                      ^

Have you been able to reproduce this locally? It’s strange, because it definitely looks like you’re importing Tropos-Swift.h in TRWeatherViewController.m.

sharplet
sharplet reviewed Jan 7, 2019
View reviewed changes
Sources/Tropos/Views/DailyForecastView.swift
@IBOutlet var lowTemperatureLabel: UILabel!
@IBOutlet var conditionsImageView: UIImageView!
@IBOutlet var contentView: DailyForecastView!
@objc public var viewModel: DailyForecastViewModel? {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe leave an extra line above here to separate this property from the group of @IBOutlet properties?

sharplet
sharplet approved these changes Jan 7, 2019
View reviewed changes
Copy link
Contributor

@sharplet sharplet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharplet sharplet sharplet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@katsuroo @sharplet