Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecated env method, bump version to 1.3.0 #65

Merged
merged 2 commits into from
Sep 24, 2024

Conversation

dorianmariecom
Copy link
Contributor

it's been deprecated for a while

@stefannibrasil
Copy link
Contributor

Thanks @dorianmariecom 🎉 Could you fix the conflict? This should be good to go once the conflict is resolved.

@dorianmariecom
Copy link
Contributor Author

@stefannibrasil done

@stefannibrasil
Copy link
Contributor

Thank you! Will cut a release this week, hopefully.

@stefannibrasil stefannibrasil merged commit 8c38cc0 into thoughtbot:main Sep 24, 2024
4 checks passed
Copy link
Member

@nickcharlton nickcharlton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed actually submitting this before it was merged, for some reason. But we should avoid doing this in future.

@@ -1,3 +1,3 @@
module ClimateControl
VERSION = "1.2.0".freeze
VERSION = "1.3.0".freeze
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't change versions outside the release commit — this makes it easier to see when the release was cut, especially as it'll include CHANGELOG entries too.

I'd also generally wait until releasing a major version. We don't know who's relying on a deprecated method, and seeing a major version coming in and then you're tests failing all of a sudden is a better hint.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I am sorry, Nick! I saw that this method had been deprecated for a while and didn't see any issues. I was planning on cutting a release announcing the deprecation. I will rollback the commit and reopen this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants