Unit Testing Blobs Fees Adjustments #151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 22, 2023
Merged
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
gabriele-0201
force-pushed
the
gab_refactor_blobs_fees
branch
from
1db33e8 to
d475f38
Compare
gabriele-0201
force-pushed
the
gab_unit_testing_blobs_fees
branch
from
db9e648 to
21e8075
Compare
This was referenced Dec 22, 2023
Merged
gabriele-0201
force-pushed
the
gab_refactor_blobs_fees
branch
from
d475f38 to
e9f4b85
Compare
gabriele-0201
force-pushed
the
gab_unit_testing_blobs_fees
branch
from
21e8075 to
0b83f5f
Compare
gabriele-0201
force-pushed
the
gab_refactor_blobs_fees
branch
from
e9f4b85 to
6dde8c3
Compare
gabriele-0201
force-pushed
the
gab_unit_testing_blobs_fees
branch
from
0b83f5f to
2e4d0ee
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
gabriele-0201
force-pushed
the
gab_refactor_blobs_fees
branch
from
6dde8c3 to
d1fe412
Compare
gabriele-0201
force-pushed
the
gab_unit_testing_blobs_fees
branch
from
2e4d0ee to
820acb4
Compare
rphmeier
reviewed
Dec 27, 2023
| >::convert(fee_multiplier); | ||
| assert_eq!(new_fee_multiplier, expected_fee_multiplier); | ||
|
|
||
| // TODO: Ensure length multiplier is update properly |
There was a problem hiding this comment.
This is addressed in #153. In this stack of PRs, I've found it useful to describe some TODOs and address them later. The problem is that I haven't left any information in the code. From now on, I will avoid this approach because, in the end, it just seems confusing to others
gabriele-0201
force-pushed
the
gab_refactor_blobs_fees
branch
from
d1fe412 to
4b7e1b3
Compare
gabriele-0201
force-pushed
the
gab_unit_testing_blobs_fees
branch
from
820acb4 to
2e0a93f
Compare
5 tasks
rphmeier
force-pushed
the
gab_unit_testing_blobs_fees
branch
from
2e0a93f to
8da344d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.