Skip to content

Revdepcheck on main #6558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Revdepcheck on main #6558

wants to merge 1 commit into from

Conversation

thomasp85
Copy link
Member

No description provided.

@thomasp85 thomasp85 requested a review from teunbrand July 18, 2025 20:09
@@ -608,6 +496,30 @@ Run `revdepcheck::cloud_details(, "applicable")` for more info
Execution halted
```

# AquaBEHER
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New failure, seems like false positive

Copy link
Collaborator

@teunbrand teunbrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a summary of the current state of affairs.

Out of the 272 total revdep failures:

  • 153 have been reported via email or issue trackers.
  • 4 emails to packages where I attempted to report the failure bounced.
  • 1 package is slated to die a natural death on CRAN through archiving.
  • 39 packages have staged changes. They either merged my PR or comitted their own fixes, but his hasn't been propagated to CRAN yet.
  • 37 packages have unmerged PRs.
  • 32 packages have upstream packages that seem to cause the problems (qqplot, ggtern, ggiraph, xpose, ggtree, ggsurvfit, ggprism, ComplexUpset, rayshader, manynet, lemon, ggpol, ggmosaic, gghalves and geomtextpath are the upstream packages)
  • 6 packages I couldn't reproduce the problem or problems are trivial (like a note about the installation size).

Since the last revdepcheck, we have 10 new packages that show problems which are decribed in the individual comments.
I've sent reminders about umerged PRs and reports on GitHub.

@@ -749,54 +661,52 @@ Run `revdepcheck::cloud_details(, "assignPOP")` for more info
Execution halted
```

# autocogs
# autograph
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Likely via upstream {manynet}

Comment on lines +2544 to +2545
── Failure ('test-ggdend.R:172:7'): ggplot doesn't have warnings for dendrograms ──
names(built_plot) not identical to c("data", "layout", "plot").
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For dendextend, this test is fixed, but uses if (packageVersion("ggplot2") >= "4.0.0")

Execution halted
```

# door
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Newcomer package with failing class tests. I've send an email.

@@ -3710,174 +3186,78 @@ Run `revdepcheck::cloud_details(, "EQUALSTATS")` for more info
Package unavailable to check Rd xrefs: ‘lmerTest’
```

# equatiomatic
# extraSuperpower
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Newcomer that fails due to some S7 subsetting thing. I don't know what the correct solution should be for their package, so I just reported it.


[ FAIL 1 | WARN 0 | SKIP 0 | PASS 32 ]
Error: Test failures
Execution halted
```

# ggVennDiagram
# ggtranslate
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New arrival with S7 problem in replacement of the <plot>@label property. I've send a PR.

```

# hesim
# hmde
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New arrival with fragile class tests (#6498). I couldn't get their package to work, so I've just reported it.

```

* checking data for non-ASCII characters ... NOTE
# MAPCtools
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New arrival, likely false positive.

```

# MKpower
# mlr3spatiotempcv
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an established package with a recent update that now started failing. I couldn't diagnose it, so I've filed an issue.

@@ -10424,6 +8850,28 @@ Run `revdepcheck::cloud_details(, "mxnorm")` for more info
All declared Imports should be used.
```

# mycolorsTB
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAICT this is due to ggtree use of ggplot internals. I've taken no action because I'm assuming this will resolve itself once ggtree updates.

@@ -15440,68 +12316,93 @@ Run `revdepcheck::cloud_details(, "tidyposterior")` for more info
Execution halted
```

# TPMplt
# topolow
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Newcomer that uses inherits(x, "margin") instead of is_margin(). I've filed an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants