Skip to content

Refactor: Separate offline and finetuning algorithms #51

Merged
merged 4 commits into from
May 23, 2023
Merged

Refactor: Separate offline and finetuning algorithms #51

merged 4 commits into from
May 23, 2023

Conversation

DT6A
Copy link
Collaborator

@DT6A DT6A commented May 22, 2023

No description provided.

@DT6A
Copy link
Collaborator Author

DT6A commented May 22, 2023

@Scitator help with linter is needed. After the move of algorithms into subdirectory (from algorithms to algorithms/offline) linter fails to run

@vkurenkov vkurenkov changed the title Move offline training to separate folders Refactor: Separate offline and finetuning algorithms May 23, 2023
vkurenkov
vkurenkov approved these changes May 23, 2023
View reviewed changes
Copy link

@vkurenkov vkurenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Scitator
Copy link
Contributor

@DT6A try add __init__.py

Scitator
Scitator suggested changes May 23, 2023
View reviewed changes
Copy link
Contributor

@Scitator Scitator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

waiting codestyle

@DT6A
Copy link
Collaborator Author

DT6A commented May 23, 2023

@Scitator done. Approve is needed

@vkurenkov vkurenkov merged commit a89ebb5 into main May 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Howuhh Howuhh Howuhh approved these changes

@Scitator Scitator Scitator approved these changes

@vkurenkov vkurenkov vkurenkov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DT6A @Scitator @vkurenkov @Howuhh