Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #916

Closed
wants to merge 1 commit into from
Closed

Update README.md #916

wants to merge 1 commit into from

Conversation

lizhenwei
Copy link

postgres need create dabase befor run tinode service,and tinode service need set environment change host "localhost" to "postgres",postgres is container name

postgres need create dabase befor run tinode service,and tinode service need set environment change host "localhost" to "postgres",postgres is container name
@or-else or-else changed the base branch from master to devel August 14, 2024 06:00
@or-else
Copy link
Contributor

or-else commented Aug 14, 2024

The missing database is already handled here:

a.poolConfig.ConnConfig.Database = ""

If configured DB is missing, then adapter connects to 'default' database which is the same as the user name. We use postgres as username

"User": "postgres",
and database postgres always exists, consequently connection succeeds.

This string --env POSTGRES_DSN=postgresql://postgres:postgres@postgres:5432/tinode is the default setting. You basically just repeat what's already the default.

What you are suggesting is not harmful, but seems redundant. Or at least you need to explain the relationship between tinode in this line postgres=# create database tinode; and tinode in this line --env POSTGRES_DSN=postgresql://postgres:postgres@postgres:5432/tinode, that it must be exactly the same database name.

See conversation here: #902

@or-else
Copy link
Contributor

or-else commented Aug 14, 2024

Or just give an explanation why the database needs to be created.

@or-else
Copy link
Contributor

or-else commented Aug 18, 2024

Any update on this?

@or-else
Copy link
Contributor

or-else commented Aug 18, 2024

@or-else
Copy link
Contributor

or-else commented Aug 27, 2024

No update in while, no answers to questions. Closing.

@or-else or-else closed this Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants