CreateSubOrgV3 #107
Merged
CreateSubOrgV3 #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
andrewkmin
force-pushed
the
andrew/suborg-v3
branch
3 times, most recently
from
1d10559 to
0c2c0e6
Compare
emostov
reviewed
Aug 30, 2023
| console.error(e); | ||
|
|
||
| res.status(500).json({ | ||
| message: "Something went wrong.", |
There was a problem hiding this comment.
will leave it out and just handle on the server side for now. don't feel too strongly either way 🤷
emostov
reviewed
Aug 30, 2023
emostov
reviewed
Aug 30, 2023
emostov
approved these changes
Aug 30, 2023
r-n-o
reviewed
Aug 31, 2023
Comment on lines
101
to
+103
| await axios.post("/api/proxyRequest", signedRequest); | ||
|
|
||
| alert(`Hooray! Key ${data.privateKeyName} created.`); | ||
| await sleep(1000); // alternative would be to poll the activity itself repeatedly | ||
| await getPrivateKeys(subOrgId); |
There was a problem hiding this comment.
A bit messy but I get why that's the simplest for now. I'm onboard 👍
r-n-o
reviewed
Aug 31, 2023
Comment on lines
151
to
176
| const privateKeysTable = ( | ||
| <div className={styles.baseTable}> | ||
| <table className={styles.table}> | ||
| <tr> | ||
| <th className={styles.th}>Name</th> | ||
| <th className={styles.th}>Address</th> | ||
| </tr> | ||
| {privateKeys.map((val, key) => { | ||
| return ( | ||
| <tr key={key}> | ||
| <td className={styles.td}>{val.privateKeyName}</td> | ||
| <td className={styles.td}>{val.privateKeyAddress}</td> | ||
| </tr> | ||
| ); | ||
| })} | ||
| </table> | ||
| </div> | ||
| ); | ||
|
|
||
| const privateKeyElements = privateKeys.map((pk) => ( | ||
| <li key={pk.privateKeyId} className={styles.prompt}> | ||
| {pk.privateKeyAddress} | ||
| </li> | ||
| )); |
There was a problem hiding this comment.
This demo is getting fancier and fancier! 😍
r-n-o
reviewed
Aug 31, 2023
andrewkmin
force-pushed
the
andrew/suborg-v3
branch
from
31af670 to
acce4a1
Compare
andrewkmin
force-pushed
the
andrew/suborg-v3
branch
from
acce4a1 to
af661c9
Compare
andrewkmin
force-pushed
the
andrew/suborg-v3
branch
from
19d98c0 to
d8586f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
How I Tested These Changes
Screen.Recording.2023-08-30.at.12.59.01.PM.mov