signMessage(...)
: move encoding and hashing logic to client side
#22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
For raw payload signing, our configuration is too inflexible -- currently we require the message to be UTF8 encoded, and we hash the payload via
KECCAK256
on the remote signer.This PR changes
signMessage(...)
to conform to whatEthers
expects,eth_sign
style:string
) or a binary message (Bytes
)PAYLOAD_ENCODING_HEXADECIMAL
), and does not apply extra hashing (HASH_FUNCTION_NO_OP
)How I Tested These Changes
CI and running internal E2E tests manually