Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary packages #403

Merged
merged 2 commits into from
Oct 18, 2024
Merged

Remove unnecessary packages #403

merged 2 commits into from
Oct 18, 2024

Conversation

zkharit
Copy link
Contributor

@zkharit zkharit commented Oct 18, 2024

Summary & Motivation

How I Tested These Changes

Did you add a changeset?

If updating one of our packages, you'll likely need to add a changeset to your PR. To do so, run pnpm changeset. pnpm changeset will generate a file where you should write a human friendly message about the changes. Note how this (example) includes the package name (should be auto added by the command) along with the type of semver change (major.minor.patch) (which you should set).

These changes will be used at release time to determine what packages to publish and how to bump their version. For more context see this comment.

@zkharit zkharit requested review from andrewkmin and moe-dev October 18, 2024 18:29
Copy link

socket-security bot commented Oct 18, 2024

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: npm/[email protected]

View full report↗︎

Copy link

codesandbox-ci bot commented Oct 18, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Collaborator

@andrewkmin andrewkmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! if builds and CI at large are green, I'm good with this. but would be nice to test this out via one of the examples

one ask: can you add a changeset for this PR? pnpm run changeset

@zkharit
Copy link
Contributor Author

zkharit commented Oct 18, 2024

Tested with export with node example, added changeset

@zkharit zkharit merged commit 0d8d28b into main Oct 18, 2024
5 checks passed
@zkharit zkharit deleted the zane/remove-unecessary-packages branch October 18, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants