Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync protos (2023-06-14) #76

Closed
wants to merge 2 commits into from
Closed

Sync protos (2023-06-14) #76

wants to merge 2 commits into from

Conversation

r-n-o
Copy link
Contributor

@r-n-o r-n-o commented Jun 14, 2023

Summary & Motivation

This might need an update once we have the actual SHA of the release tomorrow, so consider this a "draft"!

How I Tested These Changes

Not tested yet.

@r-n-o r-n-o requested review from andrewkmin and keyz-tk June 14, 2023 23:15
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 14, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@r-n-o r-n-o force-pushed the rno/sync-protos-2023-06-14 branch from 9317f51 to f1de50c Compare June 21, 2023 15:46
@r-n-o
Copy link
Contributor Author

r-n-o commented Jun 21, 2023

We released mono last night, updated this PR with the exact protos/swagger files (from mono@d3a6f81d1)

Copy link
Collaborator

@andrewkmin andrewkmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀🚀🚀

r-n-o added a commit that referenced this pull request Jun 21, 2023
@r-n-o
Copy link
Contributor Author

r-n-o commented Jun 21, 2023

Note: this PR has been merged with the following merge commit: 4e2f99e

Unsure why Github isn't marking this PR as merged right now; it may eventually mark it as such!

@r-n-o
Copy link
Contributor Author

r-n-o commented Jun 21, 2023

After looking closely: this PR was not merged correctly. The SHA merged is 9317f51, which is NOT the tip of this branch (it was the pre-rebase tip):
image

As a result the contents of packages/http/src/__generated__/services/coordinator/public/v1/ are stale. I'll open a separate PR to fix this. Closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants