Skip to content

Commit

Permalink
backport-create-issue: resolve parent only if parent has backport issues
Browse files Browse the repository at this point in the history
This fixes an edge case. If a parent issue is in "Pending Backport" status
but without any backport issues, the script (when running with --resolve-parent)
was wrongly changing the status to "Resolved".

Signed-off-by: Nathan Cutler <[email protected]>
  • Loading branch information
smithfarm committed Dec 12, 2019
1 parent 115479d commit a247904
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions src/script/backport-create-issue
Original file line number Diff line number Diff line change
Expand Up @@ -246,6 +246,8 @@ def maybe_resolve(issue, backports, dry_run):
global delay_seconds
global redmine
global status2status_id
if not backports:
return None
pending_backport_status_id = status2status_id["Pending Backport"]
resolved_status_id = status2status_id["Resolved"]
rejected_status_id = status2status_id["Rejected"]
Expand Down

0 comments on commit a247904

Please sign in to comment.