[FLINK-22288][connectors / jdbc] Remove unnecessary argument in JdbcSink

todd5167 · Apr 16, 2021 · 50af465 · 50af465
1 parent 345bf34
commit 50af465
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 7 deletions.
diff --git a/docs/content/docs/connectors/datastream/jdbc.md b/docs/content/docs/connectors/datastream/jdbc.md
@@ -168,10 +168,6 @@ env
                     ps.setInt(5, t.qty);
                 },
                 JdbcExecutionOptions.builder().build(),
-                new JdbcConnectionOptions.JdbcConnectionOptionsBuilder()
-                        .withUrl(getDbMetadata().getUrl())
-                        .withDriverName(getDbMetadata().getDriverClass())
-                        .build()),
                 JdbcExactlyOnceOptions.defaults(),
                 () -> {
                     // create a driver-specific XA DataSource

diff --git a/...nnectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/JdbcSink.java b/...nnectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/JdbcSink.java
@@ -96,15 +96,13 @@ public static <T> SinkFunction<T> sink(
      * @param <T> type of data in {@link
      *     org.apache.flink.streaming.runtime.streamrecord.StreamRecord StreamRecord}.
      * @param executionOptions parameters of execution, such as batch size and maximum retries
-     * @param connectionOptions parameters of connection, such as JDBC URL
      * @param exactlyOnceOptions exactly-once options
      * @param dataSourceSupplier supplies the {@link XADataSource}
      */
     public static <T> SinkFunction<T> exactlyOnceSink(
             String sql,
             JdbcStatementBuilder<T> statementBuilder,
             JdbcExecutionOptions executionOptions,
-            JdbcConnectionOptions connectionOptions,
             JdbcExactlyOnceOptions exactlyOnceOptions,
             SerializableSupplier<XADataSource> dataSourceSupplier) {
         return new JdbcXaSinkFunction<>(

diff --git a/...tor-jdbc/src/test/java/org/apache/flink/connector/jdbc/xa/JdbcExactlyOnceSinkE2eTest.java b/...tor-jdbc/src/test/java/org/apache/flink/connector/jdbc/xa/JdbcExactlyOnceSinkE2eTest.java
@@ -60,7 +60,6 @@ public void testInsert() throws Exception {
                                 String.format(INSERT_TEMPLATE, INPUT_TABLE),
                                 JdbcITCase.TEST_ENTRY_JDBC_STATEMENT_BUILDER,
                                 JdbcExecutionOptions.builder().build(),
-                                DERBY_EBOOKSHOP_DB.toConnectionOptions(),
                                 JdbcExactlyOnceOptions.defaults(),
                                 DERBY_EBOOKSHOP_DB::buildXaDataSource));
         env.execute();