Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update toit.tmLanguage.yaml #250

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

serjan-nasredin
Copy link

No description provided.

Copy link
Member

@floitsch floitsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that you need to run the yaml->json converter. See the top of the file for instructions

Please provide a link to the motivation behind this change: a document explaining why these should be added, or another syntax grammar that does it this way.

Please show the effect of the change (screenshot from before and after).

@@ -522,4 +522,24 @@ repository:
name: comment.line.double-slash.toit
contentName: comment.line.double-slash.toit

punctuation:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just adding this section doesn't do anything yet.

It would also needed to be added to patterns in line 243.

match: \,
- name: punctuation.definition.other.semicolon.toit
match: \;
- name: punctuation.separator.key-value.colon.toit
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typically, colons aren't just used for "key-value" in Toit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants