forked from rails/rails
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Unify to use 4 spaces indentation in CHANGELOGs [ci skip]
Especially, somehow `CHANGELOG.md` in actiontext and activestorage in master branch had used 3 spaces indentation.
- Loading branch information
Showing
5 changed files
with
68 additions
and
63 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,6 @@ | ||
* Add `ApplicationMailbox.mailbox_for` to expose mailbox routing. | ||
* Add `ApplicationMailbox.mailbox_for` to expose mailbox routing. | ||
|
||
*James Dabbs* | ||
|
||
*James Dabbs* | ||
|
||
Please check [6-0-stable](https://github.com/rails/rails/blob/6-0-stable/actionmailbox/CHANGELOG.md) for previous changes. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,21 +1,21 @@ | ||
* The `fill_in_rich_text_area` system test helper locates a Trix editor and fills it in with the given HTML: | ||
* The `fill_in_rich_text_area` system test helper locates a Trix editor and fills it in with the given HTML: | ||
|
||
```ruby | ||
# <trix-editor id="message_content" ...></trix-editor> | ||
fill_in_rich_text_area "message_content", with: "Hello <em>world!</em>" | ||
```ruby | ||
# <trix-editor id="message_content" ...></trix-editor> | ||
fill_in_rich_text_area "message_content", with: "Hello <em>world!</em>" | ||
|
||
# <trix-editor placeholder="Your message here" ...></trix-editor> | ||
fill_in_rich_text_area "Your message here", with: "Hello <em>world!</em>" | ||
# <trix-editor placeholder="Your message here" ...></trix-editor> | ||
fill_in_rich_text_area "Your message here", with: "Hello <em>world!</em>" | ||
|
||
# <trix-editor aria-label="Message content" ...></trix-editor> | ||
fill_in_rich_text_area "Message content", with: "Hello <em>world!</em>" | ||
# <trix-editor aria-label="Message content" ...></trix-editor> | ||
fill_in_rich_text_area "Message content", with: "Hello <em>world!</em>" | ||
|
||
# <input id="trix_input_1" name="message[content]" type="hidden"> | ||
# <trix-editor input="trix_input_1"></trix-editor> | ||
fill_in_rich_text_area "message[content]", with: "Hello <em>world!</em>" | ||
``` | ||
# <input id="trix_input_1" name="message[content]" type="hidden"> | ||
# <trix-editor input="trix_input_1"></trix-editor> | ||
fill_in_rich_text_area "message[content]", with: "Hello <em>world!</em>" | ||
``` | ||
|
||
*George Claghorn* | ||
*George Claghorn* | ||
|
||
|
||
Please check [6-0-stable](https://github.com/rails/rails/blob/6-0-stable/actiontext/CHANGELOG.md) for previous changes. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,59 +1,60 @@ | ||
* Image analysis is skipped if ImageMagick returns an error. | ||
* Image analysis is skipped if ImageMagick returns an error. | ||
|
||
`ActiveStorage::Analyzer::ImageAnalyzer#metadata` would previously raise a | ||
`MiniMagick::Error`, which caused persistent `ActiveStorage::AnalyzeJob` | ||
failures. It now logs the error and returns `{}`, resulting in no metadata | ||
being added to the offending image blob. | ||
`ActiveStorage::Analyzer::ImageAnalyzer#metadata` would previously raise a | ||
`MiniMagick::Error`, which caused persistent `ActiveStorage::AnalyzeJob` | ||
failures. It now logs the error and returns `{}`, resulting in no metadata | ||
being added to the offending image blob. | ||
|
||
*George Claghorn* | ||
*George Claghorn* | ||
|
||
* Method calls on singular attachments return `nil` when no file is attached. | ||
* Method calls on singular attachments return `nil` when no file is attached. | ||
|
||
Previously, assuming the following User model, `user.avatar.filename` would | ||
raise a `Module::DelegationError` if no avatar was attached: | ||
Previously, assuming the following User model, `user.avatar.filename` would | ||
raise a `Module::DelegationError` if no avatar was attached: | ||
|
||
```ruby | ||
class User < ApplicationRecord | ||
has_one_attached :avatar | ||
end | ||
``` | ||
```ruby | ||
class User < ApplicationRecord | ||
has_one_attached :avatar | ||
end | ||
``` | ||
|
||
They now return `nil`. | ||
They now return `nil`. | ||
|
||
*Matthew Tanous* | ||
*Matthew Tanous* | ||
|
||
* The mirror service supports direct uploads. | ||
* The mirror service supports direct uploads. | ||
|
||
New files are directly uploaded to the primary service. When a | ||
directly-uploaded file is attached to a record, a background job is enqueued | ||
to copy it to each secondary service. | ||
New files are directly uploaded to the primary service. When a | ||
directly-uploaded file is attached to a record, a background job is enqueued | ||
to copy it to each secondary service. | ||
|
||
Configure the queue used to process mirroring jobs by setting | ||
`config.active_storage.queues.mirror`. The default is `:active_storage_mirror`. | ||
Configure the queue used to process mirroring jobs by setting | ||
`config.active_storage.queues.mirror`. The default is `:active_storage_mirror`. | ||
|
||
*George Claghorn* | ||
*George Claghorn* | ||
|
||
* The S3 service now permits uploading files larger than 5 gigabytes. | ||
* The S3 service now permits uploading files larger than 5 gigabytes. | ||
|
||
When uploading a file greater than 100 megabytes in size, the service | ||
transparently switches to [multipart uploads](https://docs.aws.amazon.com/AmazonS3/latest/dev/mpuoverview.html) | ||
using a part size computed from the file's total size and S3's part count limit. | ||
When uploading a file greater than 100 megabytes in size, the service | ||
transparently switches to [multipart uploads](https://docs.aws.amazon.com/AmazonS3/latest/dev/mpuoverview.html) | ||
using a part size computed from the file's total size and S3's part count limit. | ||
|
||
No application changes are necessary to take advantage of this feature. You | ||
can customize the default 100 MB multipart upload threshold in your S3 | ||
service's configuration: | ||
No application changes are necessary to take advantage of this feature. You | ||
can customize the default 100 MB multipart upload threshold in your S3 | ||
service's configuration: | ||
```yaml | ||
production: | ||
service: s3 | ||
access_key_id: <%= Rails.application.credentials.dig(:aws, :access_key_id) %> | ||
secret_access_key: <%= Rails.application.credentials.dig(:aws, :secret_access_key) %> | ||
region: us-east-1 | ||
bucket: my-bucket | ||
upload: | ||
multipart_threshold: <%= 250.megabytes %> | ||
``` | ||
```yaml | ||
production: | ||
service: s3 | ||
access_key_id: <%= Rails.application.credentials.dig(:aws, :access_key_id) %> | ||
secret_access_key: <%= Rails.application.credentials.dig(:aws, :secret_access_key) %> | ||
region: us-east-1 | ||
bucket: my-bucket | ||
upload: | ||
multipart_threshold: <%= 250.megabytes %> | ||
``` | ||
*George Claghorn* | ||
*George Claghorn* | ||
Please check [6-0-stable](https://github.com/rails/rails/blob/6-0-stable/activestorage/CHANGELOG.md) for previous changes. |