Skip to content

Commit

Permalink
ubifs: CONFIG_UBIFS_FS_AUTHENTICATION should depend on UBIFS_FS
Browse files Browse the repository at this point in the history
Instead of adding yet another dependency on UBIFS_FS, wrap the whole
block of ubifs config options in a single "if UBIFS_FS".

Fixes: d8a2277 ("ubifs: Enable authentication support")
Signed-off-by: Geert Uytterhoeven <[email protected]>
Acked-by: Sascha Hauer <[email protected]>
Signed-off-by: Richard Weinberger <[email protected]>
  • Loading branch information
geertu authored and richardweinberger committed Dec 13, 2018
1 parent eb66eff commit aa3d31e
Showing 1 changed file with 7 additions and 8 deletions.
15 changes: 7 additions & 8 deletions fs/ubifs/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,10 @@ config UBIFS_FS
help
UBIFS is a file system for flash devices which works on top of UBI.

if UBIFS_FS

config UBIFS_FS_ADVANCED_COMPR
bool "Advanced compression options"
depends on UBIFS_FS
help
This option allows to explicitly choose which compressions, if any,
are enabled in UBIFS. Removing compressors means inability to read
Expand All @@ -24,22 +25,19 @@ config UBIFS_FS_ADVANCED_COMPR

config UBIFS_FS_LZO
bool "LZO compression support" if UBIFS_FS_ADVANCED_COMPR
depends on UBIFS_FS
default y
help
LZO compressor is generally faster than zlib but compresses worse.
Say 'Y' if unsure.

config UBIFS_FS_ZLIB
bool "ZLIB compression support" if UBIFS_FS_ADVANCED_COMPR
depends on UBIFS_FS
default y
help
Zlib compresses better than LZO but it is slower. Say 'Y' if unsure.

config UBIFS_ATIME_SUPPORT
bool "Access time support" if UBIFS_FS
depends on UBIFS_FS
bool "Access time support"
default n
help
Originally UBIFS did not support atime, because it looked like a bad idea due
Expand All @@ -54,7 +52,6 @@ config UBIFS_ATIME_SUPPORT

config UBIFS_FS_XATTR
bool "UBIFS XATTR support"
depends on UBIFS_FS
default y
help
Saying Y here includes support for extended attributes (xattrs).
Expand All @@ -65,7 +62,7 @@ config UBIFS_FS_XATTR

config UBIFS_FS_ENCRYPTION
bool "UBIFS Encryption"
depends on UBIFS_FS && UBIFS_FS_XATTR && BLOCK
depends on UBIFS_FS_XATTR && BLOCK
select FS_ENCRYPTION
default n
help
Expand All @@ -76,7 +73,7 @@ config UBIFS_FS_ENCRYPTION

config UBIFS_FS_SECURITY
bool "UBIFS Security Labels"
depends on UBIFS_FS && UBIFS_FS_XATTR
depends on UBIFS_FS_XATTR
default y
help
Security labels provide an access control facility to support Linux
Expand All @@ -96,3 +93,5 @@ config UBIFS_FS_AUTHENTICATION
If you say yes here you should also select a hashing algorithm such as
sha256, these are not selected automatically since there are many
different options.

endif # UBIFS_FS

0 comments on commit aa3d31e

Please sign in to comment.