Crash with MPV player fixed. Show count of audio channels. #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add channel count info.
if no video is playing pressing the Mute Button results in _mpvHandle with NULL pointer. The try / catch do not handle this.
This reverts commit 6f1f46a.
This reverts commit 1244d2d.
While no video is playing pressing the Mute Button results in a application crash. Reason: _mpvHandle has NULL pointer. The "try/catch" do not handle this.
Detection of provided count of audio channels was missing.
|
Please ignore the reverted commits. |
If audio is muted for the tuner and stream we start with Volume 100 or so here and get an annoying audio glitch. (detected with MPV player)
WinterHill has 4 video sources. Previous code was not able to handle this correctly.
The default preset settings for DefaultMuted, DefaultVolume and muted, preMute changed. These settings are used if no settings are loaded.
|
Hi Martin, Nice! Thanks for looking into this and doing a pull request :) I'd definitely like to see more people get involved like this. I'm going to merge the changes and will do some more testing, but it looks good. 73, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Tom,
I have found and fixed an application crash with the MPV player and fixed it.
Also the amount of audio channels shows always 0 channels.
I added the missing code to show this information.
Maybe it is usefull for you.
vy 73 de Martin, DL1RF