Fix top services modal bug

Service name wasn't cleared correctly
tonghuaroot · Jul 6, 2017 · d3f0cfb · d3f0cfb
1 parent 5ce2e76
commit d3f0cfb
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 0 deletions.
diff --git a/server/www/scripts/d3/directives/bar.js b/server/www/scripts/d3/directives/bar.js
@@ -84,6 +84,10 @@ angular.module('faradayApp')
                     var colored = document.createElement('div');
                     colored.style = "background-color:" + d.color; // Color is safe (its value is in a whitelist)
                     colored.innerText = name;
+                    while (element.firstChild) {
+                        // https://stackoverflow.com/questions/3955229/remove-all-child-elements-of-a-dom-node-in-javascript
+                        element.removeChild(element.firstChild);
+                    }
                     element.appendChild(colored);
                     element.appendChild(document.createTextNode(d.value));
                 })

diff --git a/server/www/scripts/d3/directives/cake.js b/server/www/scripts/d3/directives/cake.js
@@ -104,6 +104,10 @@ angular.module('faradayApp')
                     var colored = document.createElement('div');
                     colored.style = "background-color:" + d.color; // Color is safe (its value is in a whitelist)
                     colored.innerText = d.key;
+                    while (element.firstChild) {
+                        // https://stackoverflow.com/questions/3955229/remove-all-child-elements-of-a-dom-node-in-javascript
+                        element.removeChild(element.firstChild);
+                    }
                     element.appendChild(colored);
                     element.appendChild(document.createTextNode(d.value));
                 })

diff --git a/server/www/scripts/d3/directives/treemap.js b/server/www/scripts/d3/directives/treemap.js
@@ -95,6 +95,10 @@ angular.module('faradayApp')
                   var colored = document.createElement('div');
                   colored.style = "background-color:" + d.color; // Color is safe (its value is in a whitelist)
                   colored.innerText = d.name;
+                  while (element.firstChild) {
+                      // https://stackoverflow.com/questions/3955229/remove-all-child-elements-of-a-dom-node-in-javascript
+                      element.removeChild(element.firstChild);
+                  }
                   element.appendChild(colored);
                   element.appendChild(document.createTextNode(d.count));
               })