Ensure fixed order in FindFileTimeDependentTest #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The order of tests run in `org.unix4j.unix.FindFileTimeDependentTest` needs to be ensured in case the defaults change in the future (as JUnit 4 reserves the right to do); otherwise `find_fileCreatedBeforeNow` might run after tests that cause the file being tested on to no longer have the correct creation date. This issue was found and confirmed by [`iDFlakies`](https://github.com/iDFlakies/iDFlakies).
pthariensflame
added a commit
to pthariensflame/idoft
that referenced
this pull request
Nov 25, 2021
darko-marinov
pushed a commit
to TestingResearchIllinois/idoft
that referenced
this pull request
Nov 25, 2021
|
Thanks for reporting. Your fix makes sense! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The order of tests run in
org.unix4j.unix.FindFileTimeDependentTestneeds to be ensured in case the defaults change in the future (as JUnit 4 reserves the right to do); otherwisefind_fileCreatedBeforeNowmight run after tests that cause the file being tested on to no longer have the correct creation date.This issue was found and confirmed by
iDFlakies.