using placeholder for a hint to enable JavaScript #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is reset if JavaScript is active
paiv
reviewed
Apr 7, 2023
| @@ -163,7 +165,7 @@ | |||
| </script> | |||
| </head> | |||
| <body> | |||
| <div id="plaintext-wrapper"><textarea id="plaintext" spellcheck="false"></textarea></div> | |||
| <div id="plaintext-wrapper"><textarea id="plaintext" spellcheck="false" placeholder="Please enable JavaScript."></textarea></div> | |||
There was a problem hiding this comment.
I support the idea, but the canonical way is to use noscript element.
There was a problem hiding this comment.
To change placeholder? I would not know how to without using js.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for this tool! Very nice idea and easy to deploy :-)
Some people (like me) generally have JavaScript blocked, so I felt a hint would be nice to activate it.
This is using
placeholderfor this purpose, which is reset to "Enter text here." if JavaScript is active. (This could be reset to an empty string if you like that better.)Before, with JavaScript disabled, you always saw a blank input field, even if you visited a URL with content. Now it shows something like this:
